This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #1414: Full screen modal presentation style for iOS 13. #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehickinson
suggested changes
Aug 20, 2019
| @@ -180,9 +180,18 @@ class MenuViewController: UITableViewController { | |||
| private enum DoneButtonPosition { case left, right } | |||
| private typealias DoneButton = (style: UIBarButtonItem.SystemItem, position: DoneButtonPosition) | |||
|
|
|||
| private func open(_ viewController: UIViewController, doneButton: DoneButton) { | |||
| private func open(_ viewController: UIViewController, doneButton: DoneButton, | |||
| allowSwipeTodismiss: Bool = true) { | |||
There was a problem hiding this comment.
minor nit: camel case typo allowSwipeToDismiss
kylehickinson
approved these changes
Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
Fix #123: This fixes the shattered coffee cup!(orNo Bug: <message>if no relevant ticket)NSLocalizableString()Test Plan:
Check if settings screen is showing correctly on iPhone iOS 13
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement