DDG modal is not prompted when a different SE is set during onboarding

[srirambv]

Description:

DDG modal is not prompted when a different SE is set during onboarding

Steps to Reproduce

1. Set device to DE/IE/NZ/AU
2. Change to Qwant during onboarding
3. Open a new private tab, no DDG modal is prompted

Actual result:
PBSE.zip

Expected result:
Should prompt DDG as default SE for the first private tab when a different SE is set in onboarding

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.12(19.09.07.08)

Device details:
iPhone XR (iOS 13.1)

Website problems only:

• did you check with Brave Shields down?
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Found while testing #1415

[anthonypkeane]

@iccub the DDG modal should always be displayed when a user first enters PB mode

[srirambv]

DDG modal should be shown the first time PB mode is enabled for all regions except Qwant supported regions

[srirambv]

Verification passed on iPhone XR with iOS 13.1 running 1.12(19.09.10.13)

Go through onboarding:

• Set region to IE, follow through onboarding, DDG set as default in onboarding and in settings for normal/private. Open new private tab, no DDG modal shown
• Set region to IE, follow through onboarding, DDG set as default in onboarding, select custom SE in onboarding, updates SE in setting for both normal/private tab. Open new private tab, DDG modal shown
• Set region to the US, follow through onboarding, Google set as default in onboarding and in settings for normal/private. Open new private tab, DDG modal shown
• Set region to the US, follow through onboarding, Google set as default in onboarding, select custom SE in onboarding, updates SE in setting for both normal/private tab. Open new private tab, DDG modal shown

Skip Onboarding:

• Set region to IE, skip onboarding, DDG set as default in settings for normal/private. Open new private tab, no DDG modal shown
• Set region to the US, skip onboarding, Google set as default in settings for normal/private. Open new private tab, DDG modal shown

Verification PASSED on iPad Air 3rd Generation using iOS 13.1 running 1.12 (19.09.11.22):

Go through onboarding:

• Set region to IE, follow through onboarding, DDG set as default in onboarding and in settings for normal/private. Open new private tab, no DDG modal shown
• Set region to IE, follow through onboarding, DDG set as default in onboarding, select custom SE in onboarding, updates SE in setting for both normal/private tab. Open new private tab, DDG modal shown
• Set region to the US, follow through onboarding, Google set as default in onboarding and in settings for normal/private. Open new private tab, DDG modal shown
• Set region to the US, follow through onboarding, Google set as default in onboarding, select custom SE in onboarding, updates SE in setting for both normal/private tab. Open new private tab, DDG modal shown

Skip Onboarding:

• Set region to IE, skip onboarding, DDG set as default in settings for normal/private. Open new private tab, no DDG modal shown
• Set region to the US, skip onboarding, Google set as default in settings for normal/private. Open new private tab, DDG modal shown

Verification passed on iPhone 7+ with iOS 12.4.1 running 1.12(19.09.13.06)

Go through onboarding:

• Set region to IE, follow through onboarding, DDG set as default in onboarding and in settings for normal/private. Open new private tab, no DDG modal shown
• Set region to IE, follow through onboarding, DDG set as default in onboarding, select custom SE in onboarding, updates SE in setting for both normal/private tab. Open new private tab, DDG modal shown
• Set region to the US, follow through onboarding, Google set as default in onboarding and in settings for normal/private. Open new private tab, DDG modal shown
• Set region to the US, follow through onboarding, Google set as default in onboarding, select custom SE in onboarding, updates SE in setting for both normal/private tab. Open new private tab, DDG modal shown

Skip Onboarding:

• Set region to IE, skip onboarding, DDG set as default in settings for normal/private. Open new private tab, no DDG modal shown
• Set region to the US, skip onboarding, Google set as default in settings for normal/private. Open new private tab, DDG modal shown