Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Test network tokens are still shown in edit visible tokens when filtering to a specific network #7961

Closed
srirambv opened this issue Aug 25, 2023 · 1 comment · Fixed by #7972
Closed

Test network tokens are still shown in edit visible tokens when filtering to a specific network #7961

srirambv opened this issue Aug 25, 2023 · 1 comment · Fixed by #7972
Assignees
@nuo-xu
Labels
bug Epic: Brave Wallet QA Pass - iPad QA/Yes release-notes/exclude
Milestone
1.57

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 25, 2023 •
edited
Loading

Description:

Test network tokens are still shown in edit visible tokens when filtering to a specific network

Steps to Reproduce

  1. Enable show test networks in settings
  2. Enable all networks to show tokens in filter settings
  3. Disable show test networks in settings
  4. Filter edit visible tokens to a particular network
  5. Continues to show test network tokens with filtered netwrok

Actual result:

Test network tokens are still shown in edit visible tokens when filtering to a specific network

Expected result:

Should only show the tokens from selected network

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? NA
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @nuo-xu @StephenHeaps
@srirambv srirambv added this to Web3 Aug 25, 2023
@srirambv srirambv changed the title Certain tokens are still listed even if filtered to show only tokens from one network Test network tokens are still shown in edit visible tokens when filtering to a specific network Aug 25, 2023
@srirambv srirambv mentioned this issue Aug 25, 2023
Closed
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Aug 25, 2023
@nuo-xu nuo-xu mentioned this issue Aug 28, 2023
Merged
11 tasks
nuo-xu added a commit that referenced this issue Aug 28, 2023
@nuo-xu
Fix #7961: Tokens on Testnets still shown in Edit Visible Assets Scre…
96a6ef8 
…en when testnets are filtered out (#7972)
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Aug 28, 2023
nuo-xu added a commit that referenced this issue Aug 28, 2023
@nuo-xu
Fix #7961: Tokens on Testnets still shown in Edit Visible Assets Scre…
c616e68 
…en when testnets are filtered out (#7972)
@iccub iccub added this to the 1.57 milestone Aug 29, 2023
@srirambv
Copy link
Contributor Author

Verification passed on iPad Pro with iOS 16.6 running 1.57 (23.8.29.22)

  • Verified steps from issue description
  • Verified test network tokens are not listed when filtering by portfolio by network
7961.MP4

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@nuo-xu
Fix brave/brave-ios#7961: Tokens on Testnets still shown in Edit Visi…
b1ca89e 
…ble Assets Screen when testnets are filtered out (brave/brave-ios#7972)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nuo-xu nuo-xu

Labels
bug Epic: Brave Wallet QA Pass - iPad QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.57
3 participants
@nuo-xu @iccub @srirambv