Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Crash switching to Polygon in Swap #7907

Closed
StephenHeaps opened this issue Aug 21, 2023 · 1 comment · Fixed by #7908
Closed

Crash switching to Polygon in Swap #7907

StephenHeaps opened this issue Aug 21, 2023 · 1 comment · Fixed by #7908

Comments

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Aug 21, 2023

Description:

Crash when switching to Polygon in native Swap after change to use WebImageDownloader from core.

Steps to Reproduce

Swap:

  1. Open Swap
  2. Change network to Polygon
  3. Crash

Edit User Assets:

  1. Open Portfolio and tap Edit User Assets button beside filters button
  2. Optional: Change network filter to only have Polygon network selected
  3. Scroll down list until crashes

Actual result:

Crashes

Expected result:

Does not crash

Reproduces how often:

Easily reproduced

Brave Version:

v1.57+

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@StephenHeaps StephenHeaps added this to the 1.57 milestone Aug 21, 2023
@StephenHeaps StephenHeaps self-assigned this Aug 21, 2023
StephenHeaps added a commit that referenced this issue Aug 21, 2023
…7908)

Verify given `URL` is a valid before passing to `WebImageDownloader`
@github-project-automation github-project-automation bot moved this to Done in Web3 Aug 21, 2023
StephenHeaps added a commit that referenced this issue Aug 21, 2023
…7908)

Verify given `URL` is a valid before passing to `WebImageDownloader`
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.57 (23.8.24.22)

  • Verified steps from #7908
  • Verified no crash when selecting Polygon on Swap screen
  • Verified no crash when filtering tokens to Polygon network in edit visible asset screen
  • Encountered #7961
iPhone 7+ (iOS 15.7.8) iPhone 13 (iOS 16.6) iPad Pro (iOS 16.6)
7907-iPhone.7+.MP4
7907-iPhone.13.MP4
7907-iPad.Pro.MP4

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
…h invalid URL (brave/brave-ios#7908)

Verify given `URL` is a valid before passing to `WebImageDownloader`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.