Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Landing on the wrong screen after unlocking is done #7657

Closed
hffvld opened this issue Jun 28, 2023 · 2 comments · Fixed by #7682
Closed

Landing on the wrong screen after unlocking is done #7657

hffvld opened this issue Jun 28, 2023 · 2 comments · Fixed by #7682

Comments

@hffvld
Copy link
Collaborator

hffvld commented Jun 28, 2023

Description:

Landing on the wrong screen after unlocking is done

Preconditions

  • Make sure device unlock is enabled. You can enable PIN option.
  • Sync is already enabled

Steps to Reproduce

  1. Launch Brave > Tree-dot menu > Settings
  2. Sync > Observe PIN screen to unlock the device
  3. Tap Cancel > Tap Unlock again
  4. Enter correct PIN > Observe

Actual result:

  • The user is landing on Settings screen instead of Sync screen if canceling the first attempt to unlock the device and then trying to unlock it again.
  • The same issue was observed for Logins & Password screen where the user landed on a previous screen.
Unlock_Landed.to.previous.screen.mov

Expected result:

  • The user must land on Sync screen when unlocking the device by going to Sync settings.
  • The user must be able to copy or reveal the saved password when unlocking the device by going to Saved passwords settings.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.52 (23.6.28.13)
BraveCore: 1.52.129 (114.0.5735.198)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPhone 14 [iOS 16.5]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@hffvld
Copy link
Collaborator Author

hffvld commented Jun 28, 2023

I also filed this issue #7656 where the user can't go back to the previous screen from Unlock screen if tapping Cancel button. So, maybe if the fix for #7656 will be to close Unlock screen and return to the previous screen then it should also fix this issue as well since the second attempt to enter PIN will be unavailable.

@hffvld
Copy link
Collaborator Author

hffvld commented Jul 18, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.5.1]
Brave build: 1.56 (23.7.18.21)
BraveCore: 1.56.6 (115.0.5790.90)

STEPS:

  1. Launch Brave > Tree-dot menu > Settings
  2. Sync > Observe PIN screen to unlock the device
  3. Tap Cancel > Tap Unlock again
  4. Enter correct PIN > Observe

ACTUAL RESULTS:

  • Verified that a user is landing on the correct Sync settings screen

Sync_PIN.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants