Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

There is no way to close "Unlock" screen with a device gesture or back button #7656

Closed
hffvld opened this issue Jun 28, 2023 · 1 comment · Fixed by #7682
Closed

There is no way to close "Unlock" screen with a device gesture or back button #7656

hffvld opened this issue Jun 28, 2023 · 1 comment · Fixed by #7682

Comments

@hffvld
Copy link
Collaborator

hffvld commented Jun 28, 2023

Description:

There is no way to close Unlock screen with a device gesture or back button

Preconditions

  • Make sure device unlock is enabled. You can enable PIN option.
  • Sync is already enabled

Steps to Reproduce

  1. Launch Brave > Tree-dot menu > Settings
  2. Sync > Observe PIN screen to unlock the device
  3. Tap Cancel > Try to go back to a previous Settings screen > Observe that the gesture is not working
  4. The other way to repro it > Go to Logins & Passwords in Brave settings
  5. Tap on any saved account > Tap Password > Reveal or Copy > Cancel PIN unlock > Observe the same issue

Actual result:

There is no way to close "Unlock" screen with a device gesture if the user chooses to cancel the device unlock. There is no back button on the UI as well. The only way to hide that Unlock screen is to close/hide and open Brave again.

Unlock.no.back.button.mov

Expected result:

The user must be able to return to a previous menu from Unlock screen without leaving/closing/hiding Brave.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Version: 1.52 (23.6.28.13)
BraveCore: 1.52.129 (114.0.5735.198)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPhone 14 [iOS 16.5]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@hffvld
Copy link
Collaborator Author

hffvld commented Jul 19, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.5.1]
Brave build: 1.56 (23.7.18.21)
BraveCore: 1.56.6 (115.0.5790.90)

STEPS:

  1. Launch Brave > Tree-dot menu > Settings
  2. Sync > Observe PIN screen to unlock the device
  3. Tap Cancel > Verify you can go back to a previous Settings screen by tapping another Cancel button on the screen
  4. The other way to verify it > Go to Logins & Passwords in Brave settings
  5. Tap on any saved account > Tap Password > Reveal or Copy > Cancel PIN unlock > Verify you can tap Cancel to return to a previous screen

ACTUAL RESULTS:

  • Verified that canceling screen unlock is showing the screen with two buttons: Unlock and Cancel
  • Verified that a user is able to return to a previous menu from Unlock screen without leaving/closing/hiding Brave by tapping Cancel button

PIN-Cancel.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants