Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Follow up to #7432] VPN Region country flag is not shown when relaunching Brave #7449

Closed
hffvld opened this issue May 12, 2023 · 2 comments · Fixed by #7571
Closed

[Follow up to #7432] VPN Region country flag is not shown when relaunching Brave #7449

hffvld opened this issue May 12, 2023 · 2 comments · Fixed by #7571
Assignees
@soner-yuksel
Labels
bug Epic: VPN OS/iOS QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.56

Comments

@hffvld
Copy link
Collaborator

hffvld commented May 12, 2023

Description:

Follow-up to #7432

Steps to Reproduce

  1. Launch Brave > Eanble VPN
  2. In VPN Region change location to another country> In the menu on NTP check country and flag are shown
  3. Close and relaunch Brave > Open menu on NTP > Check country and flag

Actual result:

When VPN is enabled and the user is closing and reopening Brave, the country's flag is not shown anymore

VPN_flag.mov

Expected result:

The flag for the enabled county in the VPN settings must be shown

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Version: 1.51 (23.5.11.22)
BraveCore: 1.51.114 (113.0.5672.92)

  • Can you reproduce this issue with the most recent build from TestFlight? YES
  • Can you reproduce this issue with the previous version of the current build from TestFlight? YES
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPhone 14 [iOS 16.4.1]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@hffvld hffvld mentioned this issue May 12, 2023
Closed
@iccub
Copy link
Contributor

iccub commented May 15, 2023

It is a timing issue. At app launch it takes a bit of time to fetch available regions.
I think this is not a blocker but we will try to fix it, add a loading state to that screen perhaps

@soner-yuksel soner-yuksel mentioned this issue Jun 5, 2023
Merged
11 tasks
@soner-yuksel soner-yuksel added this to the 1.53 milestone Jun 7, 2023
@soner-yuksel soner-yuksel self-assigned this Jun 7, 2023
iccub pushed a commit that referenced this issue Jun 12, 2023
@soner-yuksel
Fix #7449- Ref #7413: VPN Region country flag is not shown when relau…
f5daa99 
…nching Brave - VPN profile fails to initialize after purchase (#7571)

Setting user as paying user before fetching a fresh profile
Update package Guardian_Connect to 1.8.5 release
@hffvld hffvld added the OS/iOS label Jun 29, 2023
@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.5.1 using version 1.53 (23.7.6.16)

Example Example
IMG_3327 3 IMG_3328 2

@Uni-verse Uni-verse mentioned this issue Nov 10, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@soner-yuksel
Fix brave/brave-ios#7449- Ref brave/brave-ios#7413: VPN Region countr…
6e786c6 
…y flag is not shown when relaunching Brave - VPN profile fails to initialize after purchase (brave/brave-ios#7571)

Setting user as paying user before fetching a fresh profile
Update package Guardian_Connect to 1.8.5 release
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@soner-yuksel soner-yuksel

Labels
bug Epic: VPN OS/iOS QA Pass - iPhone X QA/Yes release-notes/include
Projects
None yet
Milestone
1.56
4 participants
@soner-yuksel @iccub @Uni-verse @hffvld