Block Switch to App Notices switch no longer works

[Uni-verse]

Description:

Context:
We have had some issues with the switch in recent releases where the setting switch itself was changing state after navigating out of settings and therefore app was not blocking the switch to app notices on webpages when enabled. After fixing the issue with the switch state, it was determined that block switch to app notices which is linked to fanboy mobile notifications list is no longer blocking these type of pop ups. However, fanboy web annoyances in the content filter list seems to be blocking these now instead when enabled. This has changed since this switch was working as expected on 1.46.x with mobile pop ups.

Steps to Reproduce

1. Clean Install 1.49 (23.3.31.9)
2. Wait a few mins for scripts to load
3. Visit https://google.com/maps or twitter.com or reddit.com

Actual result:

google	twitter	reddit

Expected result:

Popups should be blocked

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily

Brave Version: 1.49 (23.3.31.9)

• Can you reproduce this issue with the most recent build from TestFlight? Yes
• Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
• Can you reproduce this issue with the current build from AppStore? Yes

Device details:

iPhone X, iOS 16.3.1

[soner-yuksel]

I am having a similar problem related with Cookie Consent Notices. I think we must fix this before releasing 1.49.
@iccub @cuba

Some examples:

[Uni-verse]

Closing as done based on 39b66f1

[Uni-verse]

Verified on iPhone X running iOS 16.3.1 using version 1.49 (23.4.3.20)

Test Plan: #7188 (comment)

• Ensured that open in app dialogs are blocked when loading reddit.com, twitter.com, linkedin.com and google.com/maps
• Ensured that Block Switch to App Notices is enabled by default on clean profile
• Ensured that disabling Block Switch to App Notices or Fanboy Mobile noticifications list will show the open in app dialogs

Default (ON)	Default (ON)	Default (ON)	Default (ON)	Default (ON)	Default (ON)
OFF	OFF	OFF	OFF	OFF	OFF