Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Switch to app notices not suppressed on new profile (switch to app stays off) #6953

Closed
Uni-verse opened this issue Feb 15, 2023 · 2 comments · Fixed by #7150
Closed

Switch to app notices not suppressed on new profile (switch to app stays off) #6953

Uni-verse opened this issue Feb 15, 2023 · 2 comments · Fixed by #7150
Assignees
@cuba
Labels
bug feature/shields/adblock iPhone QA Pass - iPhone X QA/Yes regression release-notes/include
Milestone
1.49

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 15, 2023 •
edited
Loading

Description:

Block switch to app notices is disabled by default. When enabling in the settings, it still shows off after enabling and coming back. This is causing reddit.com or twitter.com to show the switch to app prompt by default on new profile. This does not happen on 1.47.x even after you upgrade to 1.48, only new profile.

Follow up to #6881

Steps to Reproduce

  1. Install 1.48
  2. Wait a few mins for scripts to download after onboarding
  3. Load reddit.com and/or twitter.com
  4. Check for prompt
  5. Navigate to privacy settings > other privacy settings section
  6. Confirm Block 'Switch to App' Notices is disabled
  7. Enable it
  8. Go back one directory in the menu, come back to the privacy settings
  9. Observe the settings preference for Block 'Switch to App' Notices

Actual result:

Switch to app notices disabled and stays off

Example Example Example
IMG_4496 IMG_4494 IMG_4495

Expected result:

  1. Switch to app notices should be enabled
  2. Should be suppressing switch to app prompts

Reproduces how often: [Easily reproduced, Intermittent Issue]

Always

Brave Version:

1.48

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? No

Device details:

iPhone 12, iPhone XR, iPhone X
iOS 16, 15, 14

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Remember to allow time for filter lists to download upon first launch
@Uni-verse Uni-verse mentioned this issue Feb 15, 2023
Closed
@Uni-verse
Copy link
Contributor Author

@Uni-verse QA to re-test #6881 after verifying this is fixed.

cuba added a commit that referenced this issue Mar 26, 2023
@cuba
Fix #6953: Fix filter list toggle states
3ddb996
@cuba cuba mentioned this issue Mar 26, 2023
Merged
11 tasks
cuba added a commit that referenced this issue Mar 26, 2023
@cuba
Fix #6953: Save filter list settings before filter lists are downloaded
88c5117
cuba added a commit that referenced this issue Mar 27, 2023
@cuba
Fix #6953: Fix filter list toggle states (#7150)
2b97203 
* Fix #6953: Fix filter list toggle states

* Fix #6953: Save filter list settings before filter lists are downloaded
iccub pushed a commit that referenced this issue Mar 27, 2023
@cuba @iccub
Fix #6953: Fix filter list toggle states (#7150)
fef72aa 
* Fix #6953: Fix filter list toggle states

* Fix #6953: Save filter list settings before filter lists are downloaded
@iccub iccub added this to the 1.49 milestone Mar 28, 2023
@Uni-verse
Copy link
Contributor Author

Uni-verse commented Mar 31, 2023 •
edited
Loading

Verified on iPhone X running iOS 16.3.1 using version 1.49 (23.3.31.9)

Using STR from #6953 (comment)

  • Ensured block switch to app notices switch state does not change after leaving settings page
  • Ensured that switch to app notices are blocked by enabling Fanboy Annoyances List
Switch OFF Switch ON Twitter.com Reddit.com
IMG_2868 2 IMG_2869 2 IMG_2867 IMG_2870

Encountered: #7188

@Uni-verse Uni-verse mentioned this issue Apr 13, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@cuba
Fix brave/brave-ios#6953: Fix filter list toggle states (brave/brave-…
f0eb625 
…ios#7150)

* Fix brave/brave-ios#6953: Fix filter list toggle states

* Fix brave/brave-ios#6953: Save filter list settings before filter lists are downloaded
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cuba cuba

Labels
bug feature/shields/adblock iPhone QA Pass - iPhone X QA/Yes regression release-notes/include
Projects
None yet
Milestone
1.49
Development

Successfully merging a pull request may close this issue.

Fix #6953: Fix filter list toggle states brave/brave-ios
3 participants
@cuba @iccub @Uni-verse