Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

IPFS links from other apps #7129

Closed
nuo-xu opened this issue Mar 21, 2023 · 2 comments
Closed

IPFS links from other apps #7129

nuo-xu opened this issue Mar 21, 2023 · 2 comments
Assignees
@nuo-xu
Labels
Epic: Brave Wallet Epic: IPFS QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.50

Comments

@nuo-xu
Copy link
Contributor

nuo-xu commented Mar 21, 2023

When user clicks an ipfs links from other apps, it should open Brave and start the whole ipfs navigation flow.
@nuo-xu nuo-xu added this to the 1.50 milestone Mar 21, 2023
@nuo-xu nuo-xu self-assigned this Mar 21, 2023
@nuo-xu nuo-xu mentioned this issue Mar 21, 2023
Closed
@nuo-xu nuo-xu added the QA/Yes label Mar 21, 2023
@nuo-xu
Copy link
Contributor Author

nuo-xu commented Mar 23, 2023

from discusstion in https://github.com/brave/security/issues/1227
@stoletheminerals mentioned "If we plan to handle ipfs:// links from other apps (#7129) we should probably disable it in iframes. The same we did it for sms and tel schemes: #6168"
It's also good timing to switch to a whitelist (#6181 (review))

@nuo-xu nuo-xu mentioned this issue Mar 24, 2023
Merged
11 tasks
@nuo-xu nuo-xu closed this as completed Apr 11, 2023
@nuo-xu nuo-xu mentioned this issue Apr 12, 2023
Closed
@srirambv
Copy link
Contributor

Verified as part of #7013 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nuo-xu nuo-xu

Labels
Epic: Brave Wallet Epic: IPFS QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.50
Development

No branches or pull requests
2 participants
@nuo-xu @srirambv