Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

IPFS navigation support for iOS #7013

Closed
nuo-xu opened this issue Feb 24, 2023 · 1 comment · Fixed by #7127
Closed

IPFS navigation support for iOS #7013

nuo-xu opened this issue Feb 24, 2023 · 1 comment · Fixed by #7127

Comments

@nuo-xu
Copy link
Contributor

nuo-xu commented Feb 24, 2023

iOS will have three options:

  1. Ask
  2. Gateway
  3. Disabled

Ask will open an interstitial page for user to either proceed using a public gateway to resolve or disable it.

In settings, we should also provide the support for users to customize the ipfs public gateway value.

For the interstitial page and settings, please refer to what desktop has.

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.50 (24..417.16)

  • Verified steps from #7127
  • Verified a new setting for IPFS is shown under Web3 settings
  • Verified Resolve IPFS Resources is set to Ask by default
  • Verified https://dweb.link is set as default for IPFS Public Gateway Address
  • Verified https://nftstorage.link is set as default for IPFS Public Gateway Address for NFT
  • Verified able to set a different domain for both IPFS Public Gateway Address & IPFS Public Gateway Address for NFT
  • Verified visiting vitalik.eth initiates ENS resolution interstitial page
  • Verified proceed using ENS shows IPFS interstitial page
  • Verified selecting Disable on interstitial page fails to load page and sets setting to Disabled
  • Verified selecting Use a public gateway loads the page using the set default gateway
  • Verified able to view page certificate on IPFS page loaded via public gateway
  • Verified able to load ipns:// page and load interstitial page or load the public gateway page successfully
  • Verified clicking an IPFS URL like ipfs://QmX4nfgA35MiW5APoc4P815hMcH8hAt7edi5H3wXkFm485/1688.html from Notes or external app, automatically switches to Brave and loads the page
  • Verified IPFS page shows error on private tabs regardless of what setting is set
iPhone 7+ (iOS 15.7.3) iPad Pro (iOS 16.5 Beta)
7013-iPhone.7+.MP4
7013-iPad.Pro.MP4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants