Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add additional Password-protection for secondary account removal #5967

Closed
StephenHeaps opened this issue Sep 5, 2022 · 1 comment · Fixed by #6149
Closed

Add additional Password-protection for secondary account removal #5967

StephenHeaps opened this issue Sep 5, 2022 · 1 comment · Fixed by #6149
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include security
Milestone
1.45

Comments

@StephenHeaps
Copy link
Contributor

Description:

Add password protection to secondary account removal

Steps to Reproduce

  1. Import an account
  2. Try to delete the account
  3. No password protection

Additional Information

ref: brave/brave-browser#24711

example UI from desktop:
password protect account removal
@StephenHeaps StephenHeaps added this to the 1.45 milestone Sep 5, 2022
StephenHeaps added a commit that referenced this issue Sep 5, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
a476a5b 
…additional password protection in wallet)
nuo-xu pushed a commit that referenced this issue Sep 8, 2022
@StephenHeaps @nuo-xu
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
02e44c9 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 8, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
7064a36 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 12, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
b973729 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 13, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
7b3c8a4 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 20, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
0a36d46 
…additional password protection in wallet)
kylehickinson pushed a commit that referenced this issue Sep 21, 2022
@StephenHeaps @kylehickinson
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
d75570a 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 21, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
d6cc64a 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 21, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
e09b8c0 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 23, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
a36b941 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 28, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
136c37b 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 29, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
ccdf82d 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Oct 4, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
a723b64 
…additional password protection in wallet)
@StephenHeaps StephenHeaps self-assigned this Oct 6, 2022
StephenHeaps added a commit that referenced this issue Oct 6, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
acd3e39 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Oct 7, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
2158b64 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Oct 7, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
51187b5 
…additional password protection in wallet)
@StephenHeaps StephenHeaps mentioned this issue Oct 11, 2022
Merged
11 tasks
StephenHeaps added a commit that referenced this issue Oct 17, 2022
@StephenHeaps
Fix #5967: Password Protection for Secondary Account Removal (#6149)
7f89d78 
* Refactor `BiometricsPasscodeEntryView` to extract out password entry into `PasswordEntryView` so it can be re-used.

* Add `RemoveAccountConfirmationView`, integrate to replace the confirmation alert with password entry when removing a secondary account

* Separate password entry field with biometrics into `PasswordEntryField` so it can be re-used for private key password protection

* Add cancel button to modal, cleanup unneeded modifiers

* Address PR comments, fix bug where auto-lock on `RemoveAccountConfirmationView` would cause invalid wallet state where wallet is locked but displaying unlocked state (`CryptoView` was updating prior to `defaultKeyring` update).
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.45 (22.10.25.19)

  • Verified test plan from #6149
  • Verified password request is shown before removing a secondary account
  • Encountered #6271
iPhone 7+ (iOS 14.8.1) iPhone XR (iOS 15.6.1) iPad Pro (iOS 16.1)
5967-iPhone.7+.MP4
5967-iPhone.XR.MP4
5967-iPad.Pro.MP4

@srirambv srirambv mentioned this issue Nov 15, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.45
Development

Successfully merging a pull request may close this issue.

Fix #5967: Password Protection for Secondary Account Removal brave/brave-ios
2 participants
@StephenHeaps @srirambv