Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add additional Password-protection for Wallet Backup Seed reveal #5882

Closed
StephenHeaps opened this issue Aug 17, 2022 · 1 comment · Fixed by #6167
Closed

Add additional Password-protection for Wallet Backup Seed reveal #5882

StephenHeaps opened this issue Aug 17, 2022 · 1 comment · Fixed by #6167
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include security
Milestone
1.45

Comments

@StephenHeaps
Copy link
Contributor

Description:

To increase the overall security, revealing the Brave Wallet backup seed phrase from should require re-entering the wallet password

Steps to Reproduce

Always:

  1. Open & unlock Brave Wallet
  2. Tap 'Accounts' tab
  3. Tap 'Backup'
  4. No password protection

If seed phrase not backed up:

  1. Open & unlock Brave Wallet
  2. Tap banner at top of Portfolio ('Back up your wallet now to protect your crypto assets and ensure you never lose access.').
  3. No password protection

Additional Information

ref: brave/brave-browser#24534
@StephenHeaps StephenHeaps added this to the 1.45 milestone Sep 5, 2022
StephenHeaps added a commit that referenced this issue Sep 5, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
a476a5b 
…additional password protection in wallet)
nuo-xu pushed a commit that referenced this issue Sep 8, 2022
@StephenHeaps @nuo-xu
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
02e44c9 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 8, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
7064a36 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 12, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
b973729 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 13, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
7b3c8a4 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 20, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
0a36d46 
…additional password protection in wallet)
kylehickinson pushed a commit that referenced this issue Sep 21, 2022
@StephenHeaps @kylehickinson
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
d75570a 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 21, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
d6cc64a 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 21, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
e09b8c0 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 23, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
a36b941 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 28, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
136c37b 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Sep 29, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
ccdf82d 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Oct 4, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
a723b64 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Oct 6, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
acd3e39 
…additional password protection in wallet)
@StephenHeaps StephenHeaps self-assigned this Oct 6, 2022
StephenHeaps added a commit that referenced this issue Oct 7, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
2158b64 
…additional password protection in wallet)
StephenHeaps added a commit that referenced this issue Oct 7, 2022
@StephenHeaps
Update Brave Core to v1.45.26. Added TODO's for #5881, #5882, #5967 (…
51187b5 
…additional password protection in wallet)
@StephenHeaps StephenHeaps mentioned this issue Oct 12, 2022
Merged
11 tasks
StephenHeaps added a commit that referenced this issue Oct 19, 2022
@StephenHeaps
Fix #5882: Password Protection Backup Seed Phrase (#6167)
3662b5f 
* Add password protection to backup seed phrase reveal. Updated `BackupWalletView` to have an optional password entry.
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.8.1 running 1.45 (22.10.25.19)

  • Verified steps from #6167
  • Verified no second password prompt is shown during onboarding
  • Verified clicking on banner in portfolio shows password prompt before showing the backup seed phrase
  • Verified clicking on Backup in accounts tabs shows password prompt before showing the backup seed phrase
  • Verified able to view backup seed phrase via both password or biometric unlock

Verification passed on iPhone XR with iOS 15.6.1 running 1.45 (22.10.25.19)

  • Verified steps from #6167
  • Verified no second password prompt is shown during onboarding
  • Verified clicking on banner in portfolio shows password prompt before showing the backup seed phrase
  • Verified clicking on Backup in accounts tabs shows password prompt before showing the backup seed phrase
  • Verified able to view backup seed phrase via both password or biometric unlock

Verification passed on iPad Pro with iOS 16.1 running 1.45 (22.10.25.19)

  • Verified steps from #6167
  • Verified no second password prompt is shown during onboarding
  • Verified clicking on banner in portfolio shows password prompt before showing the backup seed phrase
  • Verified clicking on Backup in accounts tabs shows password prompt before showing the backup seed phrase
  • Verified able to view backup seed phrase via both password or biometric unlock

@srirambv srirambv mentioned this issue Nov 15, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.45
Development

Successfully merging a pull request may close this issue.

Fix #5882: Password Protection Backup Seed Phrase brave/brave-ios
2 participants
@StephenHeaps @srirambv