Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update error pages design. #4338

Closed
iccub opened this issue Oct 17, 2021 · 3 comments
Closed

Update error pages design. #4338

iccub opened this issue Oct 17, 2021 · 3 comments

Comments

@iccub
Copy link
Contributor

iccub commented Oct 17, 2021

The html files we use are outdated, update them according to screenshots in this ticket #483

Interstitial pages:

image

Page might charge you money:

image

Connection not private:

image

Phishing warning:

image

Malware warning:

image

Unwanted software warning:

image

@rmcfadden3
Copy link

Hi @anthonypkeane & @iccub. Here's comments for each of the error messages:

  • "This page isn't working" … lgtm. No changes
  • "This site can't be reached" … would be nice if we could give the user some recourse, e.g. "Try re-typing the URL, or opening a search engine and searching for the new URL." But if we can't, message is OK as-is.
  • "No internet" … suggest changing the title to "No internet access" and then prefacing the bullet points with a line that says "It appears you're not online. To fix this, try:"
  • "Your clock is ahead" … suggest changing this title to "Your system time is wrong" and then changing the CTA button to "Update date / time"
  • "Connect to network" … lgtm. No changes.
  • "Did you mean example.com?" … lgtm. No changes.
  • "The page ahead may try to charge you money" … suggest changing title to "The page you're trying to visit may charge you money"
  • "Your connection is not private" … lgtm. No changes.
  • "Deceptive site ahead" … lgtm. No changes.
  • "The site ahead contains malware" … suggest changing title to "The site you're trying to visit contains malware"
  • "The site ahead contains harmful programs" … suggest changing title to "The site you're trying to visit contains harmful programs"

@iccub
Copy link
Contributor Author

iccub commented Nov 1, 2021

Note to QA: Not all copy could be updated. I updated what I could.
As long as there's typos, nothing to verify 1:1 by qa in my opinion

iccub pushed a commit that referenced this issue Nov 8, 2021
)

Fix all session restore, reader-mode, error page, certificate error page, etc. bugs.
Used InternalURL and fix PrivilegedRequest.
Get rid of most of GCDWebServer code.
@iccub iccub modified the milestones: 1.32.5, 1.32.3 Nov 8, 2021
@srirambv
Copy link
Contributor

srirambv commented Nov 16, 2021

Verification passed on iPhone 7+ with iOS 14.8 running 1.32.3 (21.11.13.9)

  • Verified error pages use new design
Malware Phishing No Internet Not Private Can't Reach
image image image image image

Verification passed on iPhone XR with iOS 15.0.1 running 1.32.3 (21.11.13.9)

  • Verified error pages use new design
Malware Phishing No Internet Not Private Can't Reach
image image image image image

Verification passed on iPad Pro with iOS 15.2 Beta2 running 1.32.3 (21.11.13.9)

  • Verified error pages use new design
Malware Phishing No Internet Not Private Can't Reach
image image image image image

Verification passed on iPad 5th Gen with iOS 14 running 1.32.3 (21.11.13.9)

  • Verified error pages listed below
Malware Malware
IMG_0559 IMG_0560
Phishing Phishing
IMG_0557 IMG_0558
Not Private Not Private Site cannot be reached No Internet Insecure connection
private1 private2 site cannot be reached no internet secure connection

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.