Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update error/warning page communication and iconography & use Google Safe Browsing via proxy #483

Closed
tildelowengrimm opened this issue Nov 28, 2018 · 12 comments

Comments

@tildelowengrimm
Copy link

tildelowengrimm commented Nov 28, 2018

Description

As on desktop, we should use Google's Safe Browsing service to avoid phishing & malware.

Designs

Create responsive webpage designs that work for mobile & desktop widths.

Interstitial pages:

image

Page might charge you money:

image

Connection not private:

image

Phishing warning:

image

Malware warning:

image

Unwanted software warning:

image

Assets

Figma: https://www.figma.com/file/aJu3WGDztEWNZgwQTD9yx2/?node-id=0%3A49

Test Plan

  1. Navigate to https://testsafebrowsing.appspot.com
  2. Confirm all webpage warnings URLs display the safe browsing warning.

Notes

Given that these are webpages, the same design is used for all platforms. Android & Desktop: brave/brave-browser#7464

@jumde
Copy link
Contributor

jumde commented Nov 29, 2018

Looks like SafeBrowsing is not implemented yet: https://testsafebrowsing.appspot.com/

@jumde jumde self-assigned this Mar 5, 2019
@Brandon-T Brandon-T self-assigned this Aug 6, 2019
@anthonypkeane anthonypkeane added this to the 1.15 milestone Nov 6, 2019
@Brandon-T Brandon-T added the blocked: needs design Needs design before work can commence label Dec 9, 2019
@karenkliu karenkliu changed the title Use Google Safe Browsing (via proxy) Update error/warning page communication and iconography & Google Safe Browsing via proxy Dec 19, 2019
@karenkliu
Copy link

Designs and assets added!

@karenkliu karenkliu changed the title Update error/warning page communication and iconography & Google Safe Browsing via proxy Update error/warning page communication and iconography & use Google Safe Browsing via proxy Dec 19, 2019
@karenkliu karenkliu removed the blocked: needs design Needs design before work can commence label Dec 19, 2019
@karenkliu
Copy link

@fmarier
Copy link
Member

fmarier commented Jan 6, 2020

Note: as per the Google UI requirements the screens need to say "Google Safe Browsing" and not "Brave Safe Browsing".

I will be fixing desktop in brave/brave-browser#7614.

@fmarier
Copy link
Member

fmarier commented Jan 6, 2020

@karenkliu In addition to the "Brave Safe Browsing" bit, I noticed that the designs say "your Mac". Should that be "your device" instead since we're talking about iOS?

@karenkliu
Copy link

@fmarier Yes - sounds good to me!

@jhreis jhreis modified the milestones: 1.15, 1.16 Feb 10, 2020
@karenkliu
Copy link

Updated designs to reflect that these should be full-screen HTML pages using our web UI.

@jhreis jhreis removed this from the 1.16 milestone Apr 22, 2020
@iccub iccub added this to the 1.18 milestone Jun 10, 2020
@karenkliu
Copy link

Do you still need anything from me for this?

@anthonypkeane
Copy link

If the designs are up to date @karenkliu I don't need anything from you.

@iefremov When you have a moment can you please review this issue again. We want to implement this in iOS now. Thanks

@anthonypkeane anthonypkeane added this to the icebox milestone Sep 29, 2021
@anthonypkeane anthonypkeane assigned iccub and unassigned karenkliu Sep 29, 2021
@iccub iccub modified the milestones: icebox, 1.33 Sep 30, 2021
@iccub
Copy link
Contributor

iccub commented Oct 17, 2021

This ticket is too big and we went with using Apple's provided api for safe browsing.

Moving the 'update design' part to #4338

@iccub iccub closed this as completed Oct 17, 2021
@iccub iccub removed their assignment Oct 17, 2021
@iccub iccub removed this from the 1.33-old milestone Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
8 participants