-
Notifications
You must be signed in to change notification settings - Fork 441
Update error/warning page communication and iconography & use Google Safe Browsing via proxy #483
Comments
Looks like SafeBrowsing is not implemented yet: https://testsafebrowsing.appspot.com/ |
Designs and assets added! |
Cross-platform reference: |
Note: as per the Google UI requirements the screens need to say "Google Safe Browsing" and not "Brave Safe Browsing". I will be fixing desktop in brave/brave-browser#7614. |
@karenkliu In addition to the "Brave Safe Browsing" bit, I noticed that the designs say "your Mac". Should that be "your device" instead since we're talking about iOS? |
@fmarier Yes - sounds good to me! |
Updated designs to reflect that these should be full-screen HTML pages using our web UI. |
Do you still need anything from me for this? |
If the designs are up to date @karenkliu I don't need anything from you. @iefremov When you have a moment can you please review this issue again. We want to implement this in iOS now. Thanks |
This ticket is too big and we went with using Apple's provided api for safe browsing. Moving the 'update design' part to #4338 |
Description
As on desktop, we should use Google's Safe Browsing service to avoid phishing & malware.
Designs
Create responsive webpage designs that work for mobile & desktop widths.
Interstitial pages:
Page might charge you money:
Connection not private:
Phishing warning:
Malware warning:
Unwanted software warning:
Assets
Figma: https://www.figma.com/file/aJu3WGDztEWNZgwQTD9yx2/?node-id=0%3A49
Test Plan
Notes
Given that these are webpages, the same design is used for all platforms. Android & Desktop: brave/brave-browser#7464
The text was updated successfully, but these errors were encountered: