Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Put 'Set as default' setting on top of settings screen. #4336

Closed
iccub opened this issue Oct 17, 2021 · 1 comment · Fixed by #4416
Closed

Put 'Set as default' setting on top of settings screen. #4336

iccub opened this issue Oct 17, 2021 · 1 comment · Fixed by #4416
Assignees
@iccub
Labels
enhancement Epic: Retention Epic: Settings QA Pass - iPad QA Pass - iPhone QA/Yes
Milestone
1.33

Comments

@iccub
Copy link
Contributor

iccub commented Oct 17, 2021

No description provided.

@iccub iccub added this to the 1.32.5 milestone Oct 17, 2021
@iccub iccub self-assigned this Oct 17, 2021
iccub added a commit that referenced this issue Oct 28, 2021
@iccub
Fix #4336: Put 'Set as default' setting on top of settings screen.
2a2798a
@iccub iccub mentioned this issue Oct 28, 2021
Merged
7 tasks
iccub added a commit that referenced this issue Oct 30, 2021
@iccub
Fix #4336: Put 'Set as default' setting on top of settings screen. (#…
242fffd 
…4416)
@iccub iccub modified the milestones: 1.32.5, 1.33 Dec 1, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Dec 7, 2021

Verification PASSED on iPhone 12 running iOS 15.1.1 using the following build:

1.33 (21.12.6.21)
Example Example
IMG_0398 IMG_0399

Verification PASSED on iPhone 6+ running iOS 14.6 using the following build:

1.33 (21.12.6.21)
Example Example
IMG_0200 IMG_0201

Verification PASSED on iPad Air (3rd Gen) running iOS 15.1 using the following build:

1.33 (21.12.6.21)
Example Example
IMG_0309 IMG_0310

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement Epic: Retention Epic: Settings QA Pass - iPad QA Pass - iPhone QA/Yes
Projects
None yet
Milestone
1.33
Development

Successfully merging a pull request may close this issue.

Fix #4336: Put 'Set as default' setting on top of settings screen. brave/brave-ios
2 participants
@kjozwiak @iccub