Fix #4336: Put 'Set as default' setting on top of settings screen. (#…

…4416)
brave · Oct 30, 2021 · 242fffd · 242fffd
1 parent daba2e7
commit 242fffd
Showing 1 changed file with 16 additions and 9 deletions.
diff --git a/Client/Frontend/Settings/SettingsViewController.swift b/Client/Frontend/Settings/SettingsViewController.swift
@@ -117,6 +117,7 @@ class SettingsViewController: TableViewController {
 
     private var sections: [Static.Section] {
         var list = [
+            defaultBrowserSection,
             featuresSection,
             generalSection,
             displaySection,
@@ -172,6 +173,21 @@ class SettingsViewController: TableViewController {
         return Static.Section(header: .view(header))
     }()
 
+    private lazy var defaultBrowserSection: Static.Section = {
+        var section = Static.Section(
+            rows: [
+                .init(text: Strings.setDefaultBrowserSettingsCell, selection: { [unowned self] in
+                    guard let settingsUrl = URL(string: UIApplication.openSettingsURLString) else {
+                        return
+                    }
+                    UIApplication.shared.open(settingsUrl)
+                }, cellClass: MultilineButtonCell.self)
+            ]
+        )
+
+        return section
+    }()
+
     private lazy var featuresSection: Static.Section = {
         var section = Static.Section(
             header: .title(Strings.features),
@@ -273,15 +289,6 @@ class SettingsViewController: TableViewController {
                      option: Preferences.General.mediaAutoBackgrounding,
                      image: #imageLiteral(resourceName: "background_play_settings_icon").template)
         ])
-
-        if AppConstants.iOSVersionGreaterThanOrEqual(to: 14) && AppConstants.buildChannel == .release {
-            general.rows.append(.init(text: Strings.setDefaultBrowserSettingsCell, selection: { [unowned self] in
-                guard let settingsUrl = URL(string: UIApplication.openSettingsURLString) else {
-                    return
-                }
-                UIApplication.shared.open(settingsUrl)
-            }, cellClass: MultilineButtonCell.self))
-        }
 
         return general
     }()