Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add default browser capability #2785

Closed
snachx opened this issue Aug 6, 2020 · 9 comments · Fixed by #2862
Closed

Add default browser capability #2785

snachx opened this issue Aug 6, 2020 · 9 comments · Fixed by #2862

Comments

@snachx
Copy link

snachx commented Aug 6, 2020

Problem Description

Set as default browser in iOS/iPadOS

Feature Overview

Set as default browser in iOS/iPadOS

Implementation Details

Apple has shared its new developer guidelines regarding how to create a third-party app that can be used as a default in iOS 14

https://developer.apple.com/documentation/xcode/allowing_apps_and_websites_to_link_to_your_content/preparing_your_app_to_be_the_default_browser_or_email_client

@iccub
Copy link
Contributor

iccub commented Aug 6, 2020

Thanks, we are working on it :)

@anthonypkeane anthonypkeane added this to the 1.21 milestone Aug 12, 2020
@iccub iccub modified the milestones: 1.22, 1.20 Aug 21, 2020
@iccub iccub changed the title Set as default browser in iOS/iPadOS Add default browser capability Aug 21, 2020
@iccub iccub added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Aug 21, 2020
@iccub
Copy link
Contributor

iccub commented Aug 21, 2020

Blocked: waiting for an entitlement from Apple

@gh0sti
Copy link

gh0sti commented Aug 27, 2020

@iccub I'm guessing you emailed Apple already for the special entitlement to enable default browser? I'm surprised they are taking this long to send back the special entitlement. Unless do you think they are waiting for iOS 14.1 to push that out to browser developers?

@iccub
Copy link
Contributor

iccub commented Aug 27, 2020

Yeah, still waiting @gh0sti
basically all remaining opened tickets for upcoming release are waiting for Apple
https://github.com/brave/brave-ios/milestone/53

no official date for iOS14 too

@anthonypkeane anthonypkeane modified the milestones: 1.20, 1.21 Sep 2, 2020
@iccub iccub modified the milestones: 1.21, 1.20.1 Sep 2, 2020
@iccub iccub modified the milestones: 1.20.1, 1.20 Sep 8, 2020
@iccub iccub added Epic: UI/UX and removed blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue Epic: Accessibility labels Sep 8, 2020
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14 running 1.20(20.09.11.20)

  • Verified default browser message is shown on NTP on both normal and private tabs
Normal tab Private tab
image image
image image
  • Verified settings show a menu option to set default browser

  • Verified clicking on the settings button opens up app settings where default browser can be changed to Brave

  • Verified clicking a link from an app opens inapp browser. Clicking on Safari button opens the link in Brave when Brave is set as default browser

@gh0sti
Copy link

gh0sti commented Sep 14, 2020

will we see this in the app store this week the 1.20 update?

@iccub
Copy link
Contributor

iccub commented Sep 14, 2020

@gh0sti this or next week probably if Apple doesn't delay our app review

@hennrynusasatria
Copy link

@srirambv

Is it also applicable on iPad? The Operating System on iPad is called iPadOS now (not iOS anymore).

@kylehickinson
Copy link
Collaborator

@hennrynusasatria This is also applicable on iPad, yes. iPadOS is just a marketing term, it still runs iOS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.