Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Feature Request] Add an option to search selected text with brave #2738

Closed
tankmohit opened this issue Jul 27, 2020 · 5 comments · Fixed by #5058
Closed

[Feature Request] Add an option to search selected text with brave #2738

tankmohit opened this issue Jul 27, 2020 · 5 comments · Fixed by #5058

Comments

@tankmohit
Copy link

Problem Description

When selecting a text in any article there is no option to search it on google or any search engine without leaving brave, and have to use lookup function built inside iOS, which by default opens safari.

This feature is built directly inside Firefox iOS. please refer to the option "Search with firefox" in screenshots below

Firefox Brave
357861E4-5930-4D52-A5C2-660B7BDCBFE1 BF0684F2-A826-483B-AAC1-D3B8C048EA8B
@hennrynusasatria
Copy link

Hi @tankmohit / All

I believe that this feature can be solved on iOS 14 / iPadOS 14, with the capability of Brave iOS to become the default browser ( #2785 ), thus by clicking "Look Up", then it will redirect to Brave iOS.

I think that the "Search with Firefox" is not standard implementation.

Thank you.

@tankmohit
Copy link
Author

But this would add few extra steps to accomplish a thing. While on firefox it can be done with single tap.

@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 15, 2022

Verified completed using beta app version 1.37 (22.3.11.18)

Devices used:

iPhone 12 Pro | iOS 15.1.1
iPhone X | iOS 14.4.2
iPad (7th Gen) | iOS 15.2.1

Acceptance Criteria:

UI:

Functionality:

  • Searches in New Tab
  • Searches in New Tab in PB/Private Tab
  • Displayed when user selects text in text field
  • Displayed when user selects text on page
  • Displayed when user selects text in reader mode
  • Searches based on search engine selected in settings
  • Search query matches search from url bar https://search.brave.com/search?q={search term}&source=ios
iPhone iPad
IMG_2521 IMG_0193

@Uni-verse
Copy link
Contributor

@iccub I noticed that the searches from the context menu are not logged under recent searches. Is this the expected behavior for this feature?

cc: @cuba

@iccub
Copy link
Contributor

iccub commented Mar 15, 2022

I think this is worth having a followup ticket @Uni-verse

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants