Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Rewards button shows up on each tab when hidden in settings #1954

Closed
srirambv opened this issue Nov 14, 2019 · 1 comment
Closed

Rewards button shows up on each tab when hidden in settings #1954

srirambv opened this issue Nov 14, 2019 · 1 comment

Comments

@srirambv
Copy link
Contributor

Description:

Rewards button shows up on each tab when hidden in settings

Steps to Reproduce

  1. Clean install 1.13
  2. Disable rewards form settings
  3. Open a new tab, rewards button shows
  4. Tap on rewards button gets hidden, panel shows up below shields button

Actual result:
rewardsbutton

Expected result:
Not to show rewards button until user enables it again

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.13

Device details:
All

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Reported by community user on https://community.brave.com/t/rewards-icon-is-still-displayed-even-when-i-turn-it-off/92822/2

@srirambv
Copy link
Contributor Author

Verification passed on iPhone XR with iOS 13.2 running 1.14(19.11.20.19)

  • Verified disabling removes Rewards panel on the active tab
  • Verified opening a new tab doesn't show rewards panel
  • Verified disabling setting with PBO only and turning it off disables the rewards button on a normal tab

Verification passed on iPhone 7+ with iOS 13.2 running 1.14(19.11.20.19)

  • Verified disabling removes Rewards panel on the active tab
  • Verified opening a new tab doesn't show rewards panel
  • Verified disabling setting with PBO only and turning it off disables the rewards button on a normal tab

Verification passed on iPad Pro with iOS 13.2 running 1.14(19.11.20.19)

  • Verified disabling removes Rewards panel on the active tab
  • Verified opening a new tab doesn't show rewards panel
  • Verified disabling setting with PBO only and turning it off disables the rewards button on a normal tab

Verification passed on iPhone 6 with iOS 12.4 running 1.14(19.11.20.19)

  • Verified disabling removes Rewards panel on the active tab
  • Verified opening a new tab doesn't show rewards panel
  • Verified disabling setting with PBO only and turning it off disables the rewards button on a normal tab

Verification passed on iPad Pro with iOS 12.4 running 1.14(19.11.20.19)

  • Verified disabling removes Rewards panel on the active tab
  • Verified opening a new tab doesn't show rewards panel
  • Verified disabling setting with PBO only and turning it off disables the rewards button on a normal tab

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants