This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix:#2054: Add Changelog Release Notes for 1.14 #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjozwiak
suggested changes
Dec 3, 2019
CHANGELOG.md
Outdated
| - Added time out details for incorrect pin-code lockout. ([#443](https://github.com/brave/brave-ios/issues/443)) | ||
| - Switching to "Private Browsing Only" closes normal tabs and delete sessions. ([#580](https://github.com/brave/brave-ios/issues/580)) | ||
| - Fixed rewards button from showing up when disabled in settings. ([#1954](https://github.com/brave/brave-ios/issues/1954)) | ||
| - Fixed browser crash when attempting to clear private data on iPad-OS 13.2. ([#1951](https://github.com/brave/brave-ios/issues/1951)) |
There was a problem hiding this comment.
I don't think iPad-OS is the correct way if describing iOS. Should use something along the lines of the following:
- Fixed browser crash when clearing private data on iPad running iOS 13.2. (#1951)
There was a problem hiding this comment.
Apple calls it iPadOS (https://www.apple.com/ca/ipados/). Will remove the extra -
| - Added download preview option. ([#1467](https://github.com/brave/brave-ios/issues/1467)) | ||
| - Added user confirmation when external links try to switch apps. ([#551](https://github.com/brave/brave-ios/issues/551)) | ||
| - Added time out details for incorrect pin-code lockout. ([#443](https://github.com/brave/brave-ios/issues/443)) | ||
| - Switching to "Private Browsing Only" closes normal tabs and delete sessions. ([#580](https://github.com/brave/brave-ios/issues/580)) |
There was a problem hiding this comment.
nit: maybe adding deletes current sessions? Example:
- Switching to "Private Browsing Only" closes normal tabs and deletes current sessions. (#580)
There was a problem hiding this comment.
Adding current would make it sound only recent one and not all sessions hence kept it as delete session
kjozwiak
approved these changes
Dec 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes #2054
Submitter Checklist:
NSLocalizableString()Test Plan:
N/A
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement