Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Switching to PB mode only causes theme to mix up #1488

Closed
srirambv opened this issue Sep 5, 2019 · 2 comments
Closed

Switching to PB mode only causes theme to mix up #1488

srirambv opened this issue Sep 5, 2019 · 2 comments
Labels
bug Epic: UI/UX priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.12

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 5, 2019

Description:

Switching to PB mode only causes theme to mix up

Steps to Reproduce

  1. Set theme to light/dark
  2. Enable PB mode only from settings
  3. Scroll up/down
  4. Buttons colour changes when its out of view

Actual result:
Issue on Light theme: LightTheme.zip
Issue on Dark theme: DarkTheme.zip

Expected result:
Should change the entire settings page theme when PB mode only is toggled

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.12(19.9.4.23)

Device details:
iPhone XR (iOS 13)

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@srirambv srirambv added bug priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes release-notes/exclude Epic: UI/UX labels Sep 5, 2019
@srirambv srirambv added this to the 1.12 milestone Sep 5, 2019
jhreis added a commit that referenced this issue Sep 6, 2019
@jhreis
Fix #1488: Changing Private Browsing Only, adjusts theme correctly.
b0ee471
@jhreis
Copy link
Contributor

jhreis commented Sep 6, 2019

Fixed per b0ee471

@jhreis jhreis closed this as completed Sep 6, 2019
@srirambv
Copy link
Contributor Author

srirambv commented Sep 10, 2019 •
edited
Loading

  • Verification passed on iPhone XR with iOS 13.1 running 1.12(19.09.07.08) theme.zip

  • Verification PASSED on iPad Air 3rd Generation iOS 13.1 running 1.12 (19.09.10.18):

  • Verification passed on iPhone 7+ with 12.4.1 running 1.12(19.09.13.06)

@srirambv srirambv mentioned this issue Oct 3, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Epic: UI/UX priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
3 participants
@kjozwiak @jhreis @srirambv