Fix #1488: Changing Private Browsing Only, adjusts theme correctly.

brave · Sep 6, 2019 · b0ee471 · b0ee471
1 parent cc80f41
commit b0ee471
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/Client/Frontend/Settings/SettingsViewController.swift b/Client/Frontend/Settings/SettingsViewController.swift
@@ -291,7 +291,24 @@ class SettingsViewController: TableViewController {
                 }
             })
         ]
-        privacy.rows.append(BoolRow(title: Strings.Private_Browsing_Only, option: Preferences.Privacy.privateBrowsingOnly))
+        privacy.rows.append(
+            BoolRow(
+                title: Strings.Private_Browsing_Only,
+                option: Preferences.Privacy.privateBrowsingOnly,
+                onValueChange: {
+                    Preferences.Privacy.privateBrowsingOnly.value = $0
+
+                    // Need to flush the table, hacky, but works consistenly and well
+                    let superView = self.tableView.superview
+                    self.tableView.removeFromSuperview()
+                    DispatchQueue.main.async {
+                        // Let shield toggle change propagate, otherwise theme may not be set properly
+                        superView?.addSubview(self.tableView)
+                        self.applyTheme(self.theme)
+                    }
+                }
+            )
+        )
         return privacy
     }()