Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix promoted card url #9816

Closed
wants to merge 3 commits into from
Closed

Fix promoted card url #9816

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f74fec
Fix promoted card url
abhiklodh Aug 22, 2021
1494029
Merge branch 'brave:master' into fix-promoted-card-url
abhiklodh Sep 29, 2021
3f46a17
Merge branch 'master' into fix-promoted-card-url
abhiklodh Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...nents/brave_new_tab_ui/components/default/braveToday/cards/_articles/cardArticleLarge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,12 @@ type ArticleProps = Props & {
publisher?: BraveToday.Publisher
shouldScrollIntoView?: boolean
}

const promotedInfoUrl = 'https://brave.com/brave-today'
//
// Promoted Card URL now points to the 'https://brave.com/brave-news' instead of 'https://brave.com/brave-today'
// Clicking on promoted card opens 'https://brave.com/brave-news' instead of the article URL
// Fixed issue #17548
//
const promotedInfoUrl = 'https://brave.com/brave-news'

function onClickPromoted (e: React.MouseEvent) {
const openInNewTab = e.ctrlKey || e.metaKey
Expand All @@ -43,6 +47,7 @@ function onClickPromoted (e: React.MouseEvent) {
window.location.href = promotedInfoUrl
}
e.preventDefault()
e.stopPropagation()
}

const LargeArticle = React.forwardRef<HTMLElement, ArticleProps>(function (props: ArticleProps, forwardedRef) {
Expand All @@ -66,7 +71,7 @@ const LargeArticle = React.forwardRef<HTMLElement, ArticleProps>(function (props
onItemViewedRef.current = props.onItemViewed
? props.onItemViewed.bind(undefined, { item: props.item, uuid })
: null

React.useEffect(() => {
if (!innerRef.current) {
return
Expand Down