-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix promoted card url #9816
Fix promoted card url #9816
Conversation
This comment has been minimized.
This comment has been minimized.
My new commit now fixes the original issue. |
@nullhook Can you take a look this PR? |
Can you please squash your commits to one so I can review? |
0cbaf30
to
c80b0a8
Compare
Promoted news card now loads brave.com/brave-news Promoted tag now opens brave.com
fa02f37
to
6f74fec
Compare
@nullhook I fetched the latest commits from brave/brave-core and then squashed all my commits in one. Hope this helps. |
@nullhook I have had severe storage issues that are preventing me from further maintaining the entire codebase on my work computer. Hence I had to shift my repository to my laptop and I am facing Git issues that are not letting me squash my commits. |
Closing - apologies we didn't get a chance to properly review. We've removed the promoted functionality and brave/brave-browser#17584 has been closed |
Promoted news card now loads https://brave.com/brave-news.
Resolves brave/brave-browser#17584
After enabling Brave News, scrolling down to a promoted article and hovering on the 'Promoted' tag on the bottom right, https://brave.com/brave-today appears as the URL and clicking on it leads to the article page.
I went through the code and changed the promotedInfoUrl to https://brave.com/brave-news and made sure that simply clicking on the Promoted tag leads to https://brave.com/brave-news instead of the article.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
A detailed test plan is described in the issue.