fixed download item filename overlap

[nullhook]

Resolves brave/brave-browser#17313

The overlap was caused by a recent change we made on the UX of the download item view.
The duped filename was setting itself visible in all modes. There are various modes to take in to consideration however, we only care about the normal mode.

This is what upstream is doing: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/views/download/download_item_view.cc;l=816;bpv=0;bpt=1

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

A detailed test plan is described in the issue.

[petemill]

looks good, although wondering if there's a lint issue. 👍 when all CI passes

[bsclifton]

@petemill does look wierd; but I ran clang-format on the above patch and it came out the same 👍

[bsclifton]

Fix looks good! Tested and it works as expected 🎉 (this is after hitting Retry with wifi disconnected)

Also tested: I was able to repro bug with Nightly 1.30.23 👍

[petemill]

nice find - we just need to make it a bit more robust with the view lifecycle

[bsclifton]

Beautiful! Thanks for taking the time to move the logic into UpdateLabels 😄

I didn't see any artifacts (although didn't notice those before either) after patching this in / compiling / running it - and code is nice and clean

[petemill]

small refactor, otherwise looks good

[kjozwiak]

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.31.50 Chromium: 94.0.4606.50 (Official Build) nightly (64-bit)
-- | --
Revision | 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS | Windows 10 Version 20H2 (Build 19042.1237)

• verified the STR/Cases outlined via Illegible overlapping error text in download infobar brave-browser#17313 (comment)
• downloaded several files from https://testsafebrowsing.appspot.com and ensured it appeared correctly via the downloads bar

Paused/Interrupted	Warning after internet restored	Resumed

Example from https://testsafebrowsing.appspot.com via the Desktop Download Warnings section: