Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Keep" option on download bar displays incorrectly #18157

Closed
Brave-Matt opened this issue Sep 16, 2021 · 3 comments
Closed

"Keep" option on download bar displays incorrectly #18157

Brave-Matt opened this issue Sep 16, 2021 · 3 comments
Assignees
Labels
closed/duplicate Issue has already been reported feature/download OS/Desktop OS/macOS priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude

Comments

@Brave-Matt
Copy link

Brave-Matt commented Sep 16, 2021

Description

Downloading files from a potentially insecure source presents the option to Keep or Discard those files in the download bar. In some cases, the Keep option appears to display incorrect on the bar, although the button does still function properly.

Note that this issue may be specific to macOS.

Steps to Reproduce

  1. Ensure this setting is turned off on the Settings page
    image

  2. Download a file/files from potentially insecure site

  3. Options to Keep and/or Discard

  4. Observe Keep displays incorrectly

Actual result:

image

Reproduces how often:

Intermittent

Brave version (brave://version info)

v1.29.80

Version/Channel Information:

  • Can you reproduce this issue with the current release? Y
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? N/A

Miscellaneous Information:

Community threads reporting this issue:
https://community.brave.com/t/download-on-download-bar-information-isnt-displaying-correctly/282804?u=mattches
https://community.brave.com/t/download-on-download-bar-information-isnt-displaying-correctly/282804/8?u=mattches

@rebron
Copy link
Collaborator

rebron commented Sep 16, 2021

cc: @nullhook Can you take a look when you get a chance.?

@rebron rebron added feature/download priority/P4 Planned work. We expect to get to it "soon". labels Sep 16, 2021
@petemill
Copy link
Member

petemill commented Sep 17, 2021

note that you need this setting off to trigger this prompt:

image

@nullhook
Copy link

This issue seems to be fixed with this PR: brave/brave-core#9759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/download OS/Desktop OS/macOS priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude
Projects
None yet
Development

No branches or pull requests

4 participants