Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Tab Page: Brave Talk prompt show and hide spec (uplift to 1.28.x) #9662

Merged
merged 1 commit into from
Aug 6, 2021
Merged

New Tab Page: Brave Talk prompt show and hide spec (uplift to 1.28.x) #9662

merged 1 commit into from
Aug 6, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 5, 2021 •
edited by kjozwiak
Loading

Uplift of #9616
fix brave/brave-browser#13492
fix brave/brave-browser#16312

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team August 5, 2021 10:02
@brave-builds brave-builds self-assigned this Aug 5, 2021
@brave-builds brave-builds added this to the 1.28.x - Release milestone Aug 5, 2021
kjozwiak
kjozwiak approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.28.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #9616 (comment).

@kjozwiak kjozwiak merged commit ba83145 into 1.28.x Aug 6, 2021
@kjozwiak kjozwiak deleted the pr9616_ntp-brave-talk-prompt-show-and-dismiss_1.28.x branch August 6, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.28.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases