Brave Talk onboarding modal persists on all new tabs unless dismissed via close button

[srirambv]

Description

With new onboarding for Brave Together, the onboarding modal is only dismissed when you click on the X button. Even if you click on the together shortcut and start a video call and then open a second new tab Brave Together onboarding is still shown

Steps to Reproduce

1. Update to 1.20.73 to get Brave together onboarding on an NTP
2. Click on the together button to start a video call
3. Open a new tab, still keeps showing Brave Together onboarding and covers Rewards widget

Actual result:

Expected result:

Should dismiss onboarding if user clicks and starts a video call or navigates to a new tab

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.20.73 Chromium: 88.0.4324.79 (Official Build) nightly (64-bit)
Revision	bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS	All

Version/Channel Information:

• Can you reproduce this issue with the current release? NA
• Can you reproduce this issue with the beta channel? NA
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @petemill @bsclifton

[karenkliu]

Thank you for filing this!

[kjozwiak]

Adding QA/Blocked until we get Brave Talk enabled on main (staging) via Griffin. After it's enabled on staging, QA will be able to run through the above verification. Once we get closer to Brave Talk release date, we'll push the same change into production.

[kjozwiak]

Removing QA/Blocked as brave/brave-variations#93 was merged into main (Griffin staging).

[GeetaSarvadnya]

Verification passed on

Brave | 1.28.105 Chromium: 92.0.4515.131 (Official Build) (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1110)

• ensured that Brave Talk widget was enabled via NTP on main (staging) after launching brave via the following:
  brave.exe --variations-server-url=https://variations.bravesoftware.com/seed

• ensured that BraveTalkStudy is enabled via brave://version/?show-variations-cmd
  

• Verified the test plan from New Tab Page: Brave Talk prompt show and hide spec brave-core#9616

• ensured that the BraveTalk promo tooltip is shown in NTP when the OS clock is forwarded to 3 days

now	after 3 days

• Confirmed that the Brave Talk promo tooltip is not hidden in the NTP when NTP with promo tooltip is active for more than 4 secs
• Confirmed that the Brave Talk promo tooltip is hidden in NTP when NTP is refreshed/reload
• Confirmed that the Brave Talk promo tooltip is hidden when a new NTP is opened

initial display	after 4+ seconds and refresh	new-tab page

• Confirmed Brave Talk opens up on https://talk.brave.com/widget when Try it out is clicked in an NTP promo tooltip
• Confirmed Brave Talk promo tooltip is hidden in a new NTP

Brave Talk promo shown	opens talk.brave.com	new-tab page