Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift 1.28.x - Triggers Brave News card view event for small window sizes #9599

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Uplift 1.28.x - Triggers Brave News card view event for small window sizes #9599

merged 1 commit into from
Aug 3, 2021

Conversation

petemill
Copy link
Member

Resolves brave/brave-browser#14420 - Ads view event wasn't triggering for small window sizes because the IO threshold parameter was set to 100%. I've adjusted this parameter to 50% and stopped unnecessary triggers by holding a ref to the callback.

Also fixes brave/brave-browser#17136 (same issue)

@petemill
Merge pull request #9327 from brave/bug/promoted-article
590ae59 
[Desktop] Triggers promoted content ads view event for small window sizes
@petemill petemill added this to the 1.28.x - Beta milestone Jul 30, 2021
@petemill petemill requested a review from a team July 30, 2021 17:54
@petemill petemill requested review from samartnik and a team as code owners July 30, 2021 17:54
@petemill petemill requested review from emerick and zenparsing July 30, 2021 17:54
@petemill petemill changed the base branch from master to 1.28.x July 30, 2021 17:54
@petemill petemill removed request for a team, emerick, zenparsing and samartnik July 30, 2021 17:54
kjozwiak
kjozwiak approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.28.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per brave/brave-browser#14420 (comment) & brave/brave-browser#17136 (comment). There's also a summary of what was verified via #9327 (comment).

@kjozwiak kjozwiak merged commit 2d11b5a into 1.28.x Aug 3, 2021
@kjozwiak kjozwiak deleted the bug/promoted-article-1.28.x branch August 3, 2021 15:27
@kjozwiak kjozwiak mentioned this pull request Aug 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@petemill petemill

@nullhook nullhook

Labels
None yet
Projects
None yet
Milestone
1.28.x - Release
3 participants
@petemill @kjozwiak @nullhook