-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promoted content ads view event is not triggered for small window sizes #14420
Closed
btlechowski opened this issue
Mar 1, 2021
· 3 comments
· Fixed by brave/brave-core#9327 or brave/brave-core#9599
Closed
Promoted content ads view event is not triggered for small window sizes #14420
btlechowski opened this issue
Mar 1, 2021
· 3 comments
· Fixed by brave/brave-core#9327 or brave/brave-core#9599
Labels
feature/ads
feature/brave-news
formerly brave-today
OS/Desktop
QA Pass-Linux
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
btlechowski
added
QA/Yes
release-notes/exclude
QA/Test-Plan-Specified
OS/Desktop
feature/brave-news
formerly brave-today
labels
Mar 1, 2021
btlechowski
changed the title
ads view event is not triggered for small window sizes
Promoted content ads view event is not triggered for small window sizes
Mar 1, 2021
This was referenced Mar 17, 2021
Adding @mattmcalister to the conversation. |
24 tasks
Still reproducible
|
Verification passed on
Verified test plan from the description. Ad was marked as Verified
Verified user was paid for it:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/ads
feature/brave-news
formerly brave-today
OS/Desktop
QA Pass-Linux
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Follow up to: #13695 and #13468
The user will not be rewarded for watching the ad.
In order for the events to be triggered full ad has to be shown. For small windows size or even screen sizes(1366x768) this may not be possible.
It also could happen that the user clicks on the ad, and gets
click
, but notview
event.Steps to Reproduce
Viewed promoted content ad
Note: zoom out the page to trigger the
view
eventActual result:
Viewed promoted content ad
is never triggeredView port size:
Expected result:
Viewed promoted content ad
is triggeredReproduces how often:
100% repro rate
Brave version (brave://version info)
cc @brave/legacy_qa @tmancey @petemill @jsecretan
The text was updated successfully, but these errors were encountered: