Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cr92 followup] Revert using precompiled headers with unit tests. #9389

Merged
merged 1 commit into from
Jul 11, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jul 9, 2021

This seems to be causing an intermittent build error. See:

Fixes brave/brave-browser#16877

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This seems to be causing an intermittent build error. See:

Fixes brave/brave-browser#16877
@mkarolin mkarolin requested a review from bsclifton July 9, 2021 17:46
@mkarolin mkarolin self-assigned this Jul 9, 2021
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentative ++; waiting for unit tests on Windows here 🙂

@bsclifton bsclifton merged commit df83d1d into master Jul 11, 2021
@bsclifton bsclifton deleted the maxk-revert-prec-headers-unit-tests branch July 11, 2021 07:38
@bsclifton bsclifton added this to the 1.28.x - Nightly milestone Jul 11, 2021
mkarolin pushed a commit that referenced this pull request Jul 12, 2021
[cr92 followup] Revert using precompiled headers with unit tests.
mkarolin pushed a commit that referenced this pull request Jul 14, 2021
[cr92 followup] Revert using precompiled headers with unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cr92 followup] Revert using precompiled headers with unit/browser tests targets.
2 participants