-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speedreader: Make heuristics backend feature flag #8471
Conversation
@keur just to make sure I understand, can you clarify a couple of things?
|
@pes10k yeah. so the speedreader flag is the flag for the speedreader feature itself (it was already present. it's just included in this diff because i am adding the new feature flag below it). the speedreader heuristics backend switches to the readability backend we are using. and yeah sorry about the names i'll change it. Since the "Rules List" is the default already we don't include a flag for that. |
thanks @keur ! |
2ebaef0
to
8898dfd
Compare
note: this already passed CI, just did a name change for some variables and they timed out. unrelated. |
#if BUILDFLAG(ENABLE_SPEEDREADER_FEATURE) | ||
base::FEATURE_ENABLED_BY_DEFAULT | ||
#else | ||
base::FEATURE_DISABLED_BY_DEFAULT | ||
#endif | ||
}; | ||
|
||
const base::Feature kSpeedreaderReadabilityBackend{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a space before {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-format did this. i agree it looks kinda wonky, but it shows up in other files too
@@ -11,12 +11,15 @@ | |||
namespace speedreader { | |||
|
|||
const base::Feature kSpeedreaderFeature { | |||
"Speedreader", | |||
"Speedreader", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like bad spacing, needs clang-format ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-format also did this
8898dfd
to
66e3c22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src
changes LGTM
This is more accessible for my team than a command line switch. Resolves brave/brave-browser#15179
66e3c22
to
680fe15
Compare
This is more accessible for my team than a command line switch.
Resolves brave/brave-browser#15179
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: