Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables sharing QR code feature. #8385

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#15008

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Fixes brave/brave-browser#15008

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/60f0b23dc9b6f1f6ba5ddd8d763a4f60f2f501b5

commit 60f0b23dc9b6f1f6ba5ddd8d763a4f60f2f501b5
Author: Travis Skare <[email protected]>
Date:   Tue Feb 2 03:04:13 2021 +0000

    Mark QRCode generator enabled by default

    BUG: 982914
@mkarolin mkarolin requested review from jumde and yrliou March 30, 2021 13:52
@mkarolin mkarolin self-assigned this Mar 30, 2021
@mkarolin
Copy link
Collaborator Author

CI failures

  • RewardsNotificationBrowserTest.InsufficientNotificationForACNotEnoughFunds browser test on Linux
  • audit_deps
  • both are unrelated to this PR.

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkarolin mkarolin merged commit 6037486 into master Apr 6, 2021
@mkarolin mkarolin deleted the maxk-disable-sharing-qr branch April 6, 2021 17:07
@mkarolin mkarolin added this to the 1.24.x - Nightly milestone Apr 6, 2021
mkarolin added a commit that referenced this pull request Apr 6, 2021
kylehickinson added a commit that referenced this pull request Jan 4, 2024
* Update BraveCore to v1.61.29

* Update BraveCore to v1.61.32

* Wallet fixup

* [1.61] Fix #8252: Remove KeyringInfo Refactor & Update BraveCore to v1.61.39 (#8313)

* Update for KeyringInfo removal refactoring

* Update BraveCore to v1.61.39

* Fix MOST of the compilation (but not all - Had to comment out one rewards/ads related thing for adsInfo)

* Bump to 1.61.51, finish fixing up ads changes

* Update BraveCore to v1.61.59

* Update BraveCore to v1.61.69

---------

Co-authored-by: Brandon T <[email protected]>
Co-authored-by: Jacob Sikorski <[email protected]>
Co-authored-by: Kyle Hickinson <[email protected]>
kylehickinson added a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable sharing-qr-code-generator feature.
2 participants