-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle invalid grant notification ID #812
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently changed the format of the grant notification ID from an integer to a string. We've encountered a scenario where an old install may erroneously set the ID to 0 (which was never a valid value). Once you're in this state, it's impossible to dismiss the notification. To fix this, we look for this case on startup and modify the notification to have the correct ID.
bbondy
approved these changes
Nov 6, 2018
Uplift requested for if we respin 0.56.x Release channel, or for the next hotfix if not. |
kjozwiak
added
uplift-approved/0.56.x-Release
and removed
uplift-request/0.56.x-Release
labels
Nov 6, 2018
NejcZdovc
added a commit
that referenced
this pull request
Nov 6, 2018
Handle invalid grant notification ID
NejcZdovc
added a commit
that referenced
this pull request
Nov 6, 2018
Handle invalid grant notification ID
NejcZdovc
added a commit
that referenced
this pull request
Nov 6, 2018
Handle invalid grant notification ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#2004
We recently changed the format of the grant notification ID from an
integer to a string. We've encountered a scenario where an old install
may erroneously set the ID to 0 (which was never a valid value). Once
you're in this state, it's impossible to dismiss the notification. To
fix this, we look for this case on startup and modify the notification
to have the correct ID.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Preferences
file and in thebrave.rewards.notifications
section set id to0
Preferences
fileReviewer Checklist: