-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't dismiss grant notification #1878
Can't dismiss grant notification #1878
Comments
Ran into the same issue after updating to |
Verified passed with
Verification Passed on
Went through verification using the following build under
Verified passed with
Went through verification using the following build under
Verification passed on Windows 7 x64
Updated from 0.55.22 to 0.56.10 by using test stub installers. |
As per the test plan mentioned in #755 PR, we need to upgrade the profile in order to dismiss/remove the grant notification. As per my knowledge, we will not be able to test this defect on Windows as we don't have offline installer and don't have option to install older version and upgrade it to the latest version. |
@emerick running through brave/brave-core#755 and brave/brave-core#812 works fine but I have a profile that's affected by this and I still can't dismiss the notifications by clicking on I can provide you with the profile if you want to take a look and see what's happening. Or I can send over the Results:
|
@kjozwiak Yes, please provide the profile. Also, if you could tell me what the |
@emerick it looks like this:
I'll send you the profile in a DM on Slack 👍 |
@kjozwiak OK, it's the invalid ID issue again. Apparently it can show up as a 0 (integer) or as "0" (string); we'll need to handle both cases. |
This is going to be really hard to test on Windows due to not having the capability of downloading |
Will keep #2004 in the release notes as they're basically the same issues fixing the same problem. |
@bbondy noticed that he can't dismiss grant notifications on the latest release / test channel. His grant was made on 10/23/2018, which means it's using the old version of the notification ID which had a prepended "n". We'll need to support dismissing notifications formatted like this, for backwards compatability purposes.
The text was updated successfully, but these errors were encountered: