-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes site banner formatting for media publisher #800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
media-site-banner
branch
from
November 4, 2018 20:01
9f692ed
to
75e017c
Compare
NejcZdovc
force-pushed
the
media-site-banner
branch
from
November 4, 2018 20:17
75e017c
to
0bf4355
Compare
NejcZdovc
requested review from
bridiver,
SergeyZhukovsky,
jasonrsadler and
ryanml
November 5, 2018 07:08
NejcZdovc
force-pushed
the
media-site-banner
branch
from
November 5, 2018 07:09
0bf4355
to
9e0aacd
Compare
NejcZdovc
force-pushed
the
media-site-banner
branch
3 times, most recently
from
November 5, 2018 07:54
231f3b4
to
99d5f59
Compare
NejcZdovc
requested review from
emerick
and removed request for
SergeyZhukovsky
November 5, 2018 08:35
@NejcZdovc please rebase |
NejcZdovc
force-pushed
the
media-site-banner
branch
from
November 5, 2018 13:02
99d5f59
to
4c189ec
Compare
@jasonrsadler rebased |
jasonrsadler
approved these changes
Nov 5, 2018
NejcZdovc
pushed a commit
that referenced
this pull request
Nov 7, 2018
Fixes site banner formatting for media publisher
per @mandar-brave request adding uplift label |
kjozwiak
added
uplift-approved/0.57.x-Beta
and removed
uplift-request/0.57.x-Beta
labels
Nov 19, 2018
@NejcZdovc approved uplift to |
NejcZdovc
pushed a commit
that referenced
this pull request
Nov 20, 2018
Fixes site banner formatting for media publisher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#1924
UI implementation: brave/brave-ui#259
Native implementation: brave-intl/bat-native-ledger#167
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: