Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes site banner formatting for media publisher #800

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 4, 2018

Resolves brave/brave-browser#1924

UI implementation: brave/brave-ui#259
Native implementation: brave-intl/bat-native-ledger#167

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • go to brave.com
  • click on bat logo and click donate
  • make sure that you see brave.com written in the banner (favicon will not work yet)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jasonrsadler
Copy link
Contributor

@NejcZdovc please rebase

@NejcZdovc
Copy link
Contributor Author

@jasonrsadler rebased

@jasonrsadler jasonrsadler merged commit 467d06e into master Nov 5, 2018
@jasonrsadler
Copy link
Contributor

jasonrsadler commented Nov 5, 2018

master (0.59.x): 467d06e
0.58.x 147136b
0.57.x 22e7cb8

@jasonrsadler jasonrsadler deleted the media-site-banner branch November 5, 2018 14:09
NejcZdovc pushed a commit that referenced this pull request Nov 7, 2018
Fixes site banner formatting for media publisher
@NejcZdovc
Copy link
Contributor Author

per @mandar-brave request adding uplift label

@kjozwiak
Copy link
Member

kjozwiak commented Nov 19, 2018

@NejcZdovc approved uplift to 0.57.x after deliberating with @rebron.

NejcZdovc pushed a commit that referenced this pull request Nov 20, 2018
Fixes site banner formatting for media publisher
@bbondy bbondy added this to the 0.57.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use media publisher name and favicon in site banner
4 participants