-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use media publisher name and favicon in site banner #1924
Comments
Requesting uplift to 0.57 Beta. |
Thanks @mandar-brave, just a heads up for the future, uplift labels should be used on the PR's associated with the issue and not the issue itself. |
@NejcZdovc it's expected that we don't add 'on YouTube' on the site banner, correct? Just wondering as we do have this 'on YouTube' text on the panel and brave://rewards page (see below). |
Per discussion with @NejcZdovc logged #2238 for the missing 'on YouTube' text on site banner. |
Verified passed with
Verification Passed on
Verification passed on
|
Description
We need to show media publisher name and favicon in site banner circle if publisher don't provide custom image. We should do the same for regular sites regarding favicon. We need to pass name and favicon into webui. If publisher is media we should pass publisher name, if regular site we should pass in domain as name.
Steps to Reproduce
Actual result:
Expected result:
Reproduces how often:
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: