Upgrade from Chromium 89 to Chromium 90. #7866

…0.4399.0.

The logic affected by our patch has moved to ThemeUtils.java now. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/bfdfa6488a2a0babca504fd614b43eb54fc0d864 commit bfdfa6488a2a0babca504fd614b43eb54fc0d864 Author: Jinsuk Kim <[email protected]> Date: Wed Jan 20 06:06:30 2021 +0000 Toolbar: Remove deps on feature flags Removes the dependencies on the following flags. They are now passed from ToolbarManager through ctors/setters: - TabUiFeatureUtilities.isGridTabSwitcherEnabled() - TabUiFeatureUtilities.isTabToGtsAnimationEnabled() - StartSurfaceConfiguration.isStartSurfaceEnabled() - VrModuleProvider.getDelegate().isInVr() This change allows following toolbar classes to be in the modularized target: - NewTabButton - ProgressAnimationSmooth - ToolbarProgressBar/Test - LoadProgressCoordinator MVC/Test - TabSwitcherButtonCoordinator MVC - TopToolbarOverlayCoordinator MVC - TopToolbarSceneLayer Bug: 1127732

Some parts belong in notification_platform_bridge_mac_utils.mm now. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/4737f9a9625b17bbe7b8d3387823c8eef84f6d2b commit 4737f9a9625b17bbe7b8d3387823c8eef84f6d2b Author: Richard Knoll <[email protected]> Date: Thu Jan 21 12:52:59 2021 +0000 Remove NotificationCenter from AlertDispatcher This refactors the macOS AlertDispatcher interface to no longer require an instance of NSUserNotificationCenter to be passed in. We expect the caller to query their local NotificationCenter instead and merge the results. This allows us to use the same interface in a future CL for the UNNotification API. Bug: 1127306

The file shared_user_script_manager.h has been now renamed into extension_user_script_manager.h to friend it with BraveWalletService, so we need to adapt the patch along with usage in BraveWalletService. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/7442f490d1dd79447cc3133ce19e8cfedc6fac17 commit 7442f490d1dd79447cc3133ce19e8cfedc6fac17 Author: Kelvin Jiang <[email protected]> Date: Thu Jan 21 01:59:17 2021 +0000 [Extensions] s/SharedUserScriptManager/ExtensionUserScriptManager declarative extension user scripts (from RequestContentScript/dynamic content scripts API/webview) will all be moved into ExtensionUserScriptManager. This rename is the first step of that process. Bug: 1168627

This is no longer supported after a period of supporting the old "whitelist" key along with the new "allowlist" one, but now we need to migrate for real. Chromium changes: https://chromium.googlesource.com/chromium/src.git/+/dc12ff7d11e5de868005e17df701d8b0c3730a1c commit dc12ff7d11e5de868005e17df701d8b0c3730a1c Author: Karandeep Bhatia <[email protected]> Date: Thu Jan 14 14:19:40 2021 +0000 Use auto-generated manifest parsing for import, export manifest keys. Also - Remove support for legacy export.whitelist manifest key. - This also revealed that json_schema_compiler doesn't correctly handle C++ reserved keywords (like export) correctly in the auto-generated code since using them directly causes compilation errors. Fix this. BUG=1113513, 842354 https://chromium.googlesource.com/chromium/src.git/+/9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4 commit 9486b056f09a97fb2ba5ebb1b4c00f2dae6630c4 Author: Devlin Cronin <[email protected]> Date: Fri May 18 05:42:04 2018 +0000 [Extensions] Use `allowlist` in SharedModule code Rename the shared module property to 'allowlist'. The legacy 'whitelist' key will continue to work until we update any uses of it. Bug: 842354

This is no longer used upstream, we need to drop it from our override to prevent the build from failing (i.e. "unused variable" error). Chromium changes: https://chromium.googlesource.com/chromium/src.git/+/bdc683ae835c48e61ec26d28310d36a7e959b0e4 commit bdc683ae835c48e61ec26d28310d36a7e959b0e4 Author: Evan Stade <[email protected]> Date: Tue Jan 19 17:07:16 2021 +0000 Move GetWebPageMetadata into webapps component Bug: 1164069

This method has been removed upstream along with other code that is now dead due to the removal of Flash. Chromium changes: https://chromium.googlesource.com/chromium/src.git/+/c93779bd112cff999d3a14519146dd5798c23a74 commit c93779bd112cff999d3a14519146dd5798c23a74 Author: Joshua Pawlicki <[email protected]> Date: Wed Jan 20 20:35:23 2021 +0000 Remove plugins <-> component updater integration Bug: 1168582

This returns a double now, instead of an int. Chromium changes: https://chromium.googlesource.com/chromium/src.git/+/abb0ef991720bf5394a20f5cf77270ce923b72c9 commit abb0ef991720bf5394a20f5cf77270ce923b72c9 Author: Sorin Jianu <[email protected]> Date: Wed Jan 20 04:21:32 2021 +0000 Change the return type of Configurator::InitialDelay from int to double. This allows the Configurator::InitialDelay function to return sub-second values for unit-testing and functional-testing of //chrome/updater. The code in the CUS service was changed to convert from double to a TimeDelta. Also, the Configurator code was changed to parse a literal to double. Where possible, the type was changed from int to double. In general, the standard conversion from int to double is used (for instance in unit tests). It's possible that there might be cases where a truncation from double to int occurs (because these call sites were missed) but this should not create an issue at runtime because the values involved in the initial delay are small. Bug: 1144151

This was probably being transitively included before.

Chromium changes: https://chromium.googlesource.com/chromium/src.git/+/c70f317d3ff08082bde54dd12f2976809d719736 commit c70f317d3ff08082bde54dd12f2976809d719736 Author: Peter Kasting <[email protected]> Date: Fri Jan 22 23:31:25 2021 +0000 Add metadata for various View subclasses that lack it, 2/n Bug: 1159562

That method does no longer exist, we need to override SetMode() now. Chromium changes: https://chromium.googlesource.com/chromium/src.git/+/5a77327519b1f970074c9eb593d1ea17fa18972e commit 5a77327519b1f970074c9eb593d1ea17fa18972e Author: Peter Kasting <[email protected]> Date: Thu Jan 21 03:54:49 2021 +0000 Add metadata for more browser objects that are commonly visible. Bug: 1159562

This has been dropped upstream now. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/66a6bb328d7da6635b2702e4f8a18870bcfe8bd4 commit 66a6bb328d7da6635b2702e4f8a18870bcfe8bd4 Author: Toby Huang <[email protected]> Date: Tue Jan 19 19:21:36 2021 +0000 LSU: Remove legacy supervised user UIs and strings Legacy supervised users are now deprecated. This CL removes some dead UI code and strings. Bug: 1164090 Change-Id: I895ad42c4c336889aebb57112ca80ef622594e4e

View() has been dropped upstream and replaced everywhere already. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/ec183d300d2b5fbeecdc9d2549b682035bc6191c commit ec183d300d2b5fbeecdc9d2549b682035bc6191c Author: Canon Mukai <[email protected]> Date: Fri Jan 22 01:01:09 2021 +0000 bindings: Replace View() with Get() (NotShared) Get() does the same thing as View() and it is recommended to use Get() instead of View(). So replaced View() with Get() and deleted View(). Also delete Get() where it can be omitted.

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/f93f7009922b5df2791d8ed64bef478f2c0ebf54 commit f93f7009922b5df2791d8ed64bef478f2c0ebf54 Author: Toby Huang <[email protected]> Date: Sun Jan 24 01:08:13 2021 +0000 LSU: Remove IsLegacySupervised() This CL removes IsLegacySupervised() from profile.h and profile_attributes_entry.h and assumes this function always returns false. This assumption holds because we have not seen a legacy supervised user (LSU) sign in on ChromeOS since M74, when LSU cryptohomes were hidden from the login screen. Bug: 1169945

Before Chromium 90, both TestingProfile and TestingProfile::Builder did use base::Optional<bool> for their internal |is_new_profile| attribute, and calling TestingProfile::IsNewProfile() without having explicitly provided a value for |is_new_profile| via OverrideIsNewProfile() would result on returning the value returned by Profile::IsNewProfile(): bool TestingProfile::IsNewProfile() const { if (is_new_profile_.has_value()) return is_new_profile_.value(); return Profile::IsNewProfile(); } But now that Profile::IsNewProfile() is a pure virtual function, the |is_new_profile| attribute of TestingProfile is no longer an optional value, but a bool initialized to false. Therefore, it is now mandatory to initialize its counterpart in TestingProfile::Builder explicitly in order to make it clear that we're building a new testing profile. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/52208fa33df1dc2174fb044cf777eeecad38838d commit 52208fa33df1dc2174fb044cf777eeecad38838d Author: Glen Robertson <[email protected]> Date: Fri Jan 15 07:10:38 2021 +0000 Push Profile::IsNewProfile down to subclasses, remove dep on first_run. TestingProfile::IsNewProfile now defaults to false instead of defaulting to the impl's behaviour when not overridden. profile.cc's inclusion of first_run.h was its last dependency on //c/b/... except for constants that have separate GN targets, and profile_observer. Removing the dependency allows profile.{cc,h} and profile_observer.h to be moved from //c/b:browser to a separate GN target (will be done in subsequent CL). This will let us break dependency cycles and improve modularization of the codebase. Bug: 1149277

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/afd16b5973b054f53733695ce33708ef430a0b83 Toolbar: Remove deps on TrackerFactory Removes deps on TrackerFactory in ToolbarTabControllerImpl and move it to the modularized toolbar/. There are a few more classes that can also be moved: ToolbarTabControllerImplTest.java ToolbarTabControllerImpl.java top/IncognitoSwitchCoordinator.java top/IncognitoSwitchProperties.java top/IncognitoSwitchViewBinder.java top/TabSwitcherActionMenuCoordinator.java top/TabSwitcherActionMenuRenderTest.java Bug: 1127732

Needed to avoid build errors like ../../brave/browser/android/preferences/brave_pref_service_bridge.cc:56:7: error: invalid use of incomplete type 'GURL'

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/bfdfa6488a2a0babca504fd614b43eb54fc0d864 Toolbar: Remove deps on feature flags Removes the dependencies on the following flags. They are now passed from ToolbarManager through ctors/setters: - TabUiFeatureUtilities.isGridTabSwitcherEnabled() - TabUiFeatureUtilities.isTabToGtsAnimationEnabled() - StartSurfaceConfiguration.isStartSurfaceEnabled() - VrModuleProvider.getDelegate().isInVr() This change allows following toolbar classes to be in the modularized target: - NewTabButton - ProgressAnimationSmooth - ToolbarProgressBar/Test - LoadProgressCoordinator MVC/Test - TabSwitcherButtonCoordinator MVC - TopToolbarOverlayCoordinator MVC - TopToolbarSceneLayer Bug: 1127732

Due to the removal of flash, navigator.plugins will always report an empty array from now on, so Brave needs to adapt its farbling mechanism to work like this depending on the selected behavior: * "off": return the real navigators.plugins, that is, an empty array. * "balanced" or "maximum": return 2 randomly generated fake plugins. Additionally, we need to adapt the browser tests to account for this new scenario, and test that indeed the expectation of navigator.plugins returning an empty array stays true. Issues in Brave's GitHub related to the implementation of this feature: * Fingerprinting 2.0: Plugins brave/brave-browser#9435 * Fingerprinting 2.0: Plugins (word replacement) brave/brave-browser#10597 Chromium change: https://chromium.googlesource.com/chromium/src.git/+/f8fe422e0e8a026f73f9d74d26f75c3c93102030 commit f8fe422e0e8a026f73f9d74d26f75c3c93102030 Author: Mason Freed <[email protected]> Date: Wed Jan 20 18:50:56 2021 +0000 Empty out navigator.plugins and navigator.mimeTypes With this CL, navigator.plugins and navigator.mimeTypes will both return empty arrays. With the removal of Flash, there is no longer the need to return anything for navigator.plugins and navigator.mimeTypes. These APIs were used primarily for a) probing for Flash player support, or b) fingerprinting. As such, we'd like to return empty for these two properties. Gecko already switched to returning *only* Flash starting with Firefox 52, and returning empty as of Firefox 85. I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/bbxAGu90LgM Fixed: 1164635

No need in this fix anymore

It is not used in Brave at the moment Chromium change: https://chromium.googlesource.com/chromium/src.git/+/a8c85be9b64f54fe88ae0b25206451cc983bf237 Safety check on Android: enabled on ToT Bug: 1070620

Fixes error ../../brave/android/java/org/chromium/chrome/browser/app/BraveActivity.java:169: Error: Overriding method should call super.onPauseWithNative [MissingSuperCall]

…4408.0.

This is mandatory now upstream, otherwise the build will fail. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/aa0c216c0236a118e51e0e4f07c8ee48667c7004 commit aa0c216c0236a118e51e0e4f07c8ee48667c7004 Author: dpapad <[email protected]> Date: Mon Feb 1 19:01:58 2021 +0000 Grit: Force all generated files to specify a resource_path attribute. - Remove Grit logic to replace the gen folder with "@out_folder@" when generating GritResourceMap keys. - Instead add an assertion to ensure that generated files use |resource_path| to specify keys for the GritResourceMap. Note that the assertion is applied only in grd files that specify an output type of "resource_map_source". Also remove an alias in shared_resources_data_source.cc that was needed for android_clang_arm builds (see explanation at [1]). The workaround is no longer necessary as the files in question are added to grd files using generate_grd(), and they are leveraging |resource_path|, and not using the output folder location as GritResourceMap keys anymore. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1020284#c45 Fixed: 1171239

ProfileAttributesStorage::GetProfileAttributesWithPath() now returns a ProfileAttributesEntry value (or nullptr), instead of accepting an out parameter. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/32c25e13fbddcc93012edf83e7a340e66608f372 commit 32c25e13fbddcc93012edf83e7a340e66608f372 Author: Alex Ilin <[email protected]> Date: Wed Feb 3 16:24:37 2021 +0000 [profiles] Refactor GetProfileAttributesWithPath method ProfileAttributesStorage::GetProfileAttributesWithPath() used an output parameter + boolean return value for returning ProfileAttributesEntry*. This CL replaces this API with simply returning ProfileAttributesEntry* from the method. In case of failure, the method returns a nullptr. Return values are preferred over output parameters: they improve readability, and ofter provide the same or better performance [1]. [1] https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs Change-Id: I6aa6c01af8660ac0b013407237360c8ed7f9a176

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/a20d48de5c668c3ed1c04721be0aa6d165b17a8d commit a20d48de5c668c3ed1c04721be0aa6d165b17a8d Author: Jan Wilken Dörrie <[email protected]> Date: Fri Jan 29 18:10:21 2021 +0000 [base] Replace StringPiece(Iter, Iter) with MakeStringPiece This change removes the BasicStringPiece constructor from a pair of iterators in favor of a MakeBasicStringPiece factory function having the same effect. While std::basic_string_view can be constructed from a pair of iterators in C++20 this is not possible in C++17. Leaving this constructor would thus block the adoption of std::string_view once Chromium is compiled with -std=c++17. Bug: 1049498

…ages ChromeMsgStart is now gone upstream and we really don't care much about which starter is used as long as we don't have to patch Chromium. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/5645a61daa85f327d6301935a40142ceea60c23b commit 5645a61daa85f327d6301935a40142ceea60c23b Author: Julie Jeongeun Kim <[email protected]> Date: Wed Jan 27 11:16:13 2021 +0000 [printing] Clean up files related to legacy IPCs This CL cleans up print_messages.{cc,h} and following files since printing IPC messages have been fully converted to mojo interfaces. - components/printing/common/print_messages.cc - components/printing/common/print_messages.h - components/printing/common/printing_param_traits.cc - components/printing/common/printing_param_traits.h - components/printing/common/printing_param_traits_macros.h - components/printing/common/printing_param_traits_unittest.cc Bug: 1008939

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/dc61eb7a0868bb61611a5026732a730e8c12959e commit dc61eb7a0868bb61611a5026732a730e8c12959e Author: Elaine Chien <[email protected]> Date: Thu Jan 28 00:10:15 2021 +0000 Add metadata to bubble_frame_view Bug: 1159562

…pl.h Chromium change: https://chromium.googlesource.com/chromium/src.git/+/d00f800f7d6372decfce0f897c54bab3e43e99b1 commit d00f800f7d6372decfce0f897c54bab3e43e99b1 Author: Victor Hugo Vianna Silva <[email protected]> Date: Mon Feb 1 15:18:45 2021 +0000 [Sync Model/Engine split] Merge {model,engine}_impl with {model,engine} The distinction between the impl and non-impl directories has become unclear over time, as well as the dependencies between them. This CL merges them. This will allow us to create separate build targets for engine/ and model/ (model/ depends on engine/). Subdirectories are merged correspondingly, e.g. engine_impl/cycle/ is merged with engine/cycle/. Orthogonal to this, we remove 1 unnecessary engine/ dependency from components/password_manager/core/browser/DEPS, and make some net/ dependencies more specific in sync/ DEPS. [email protected] Bug: 947443

This helper function has moved to //components/embedder_support now. Chromium change: https://source.chromium.org/chromium/chromium/src/+/ec1fc69e5b0421dbb3f81fb080f186947e41b98b commit ec1fc69e5b0421dbb3f81fb080f186947e41b98b Author: John Abd-El-Malek <[email protected]> Date: Thu Jan 28 19:14:41 2021 +0000 Share user agent code between Chrome and WebLayer so that they remain in sync. Remove WebLayer's copy of these methods which wasn't exactly the same and use the same logic as Chrome. Bug: 1170830

Chromium change: https://source.chromium.org/chromium/chromium/src/+/616ef2d03906107acc6f7fec1fe8a9edb97b7c09 commit 616ef2d03906107acc6f7fec1fe8a9edb97b7c09 Author: Reilly Grant <[email protected]> Date: Tue Feb 2 03:17:48 2021 +0000 Add help center links to the serial and HID choosers This change adds a help button to the WebHID and Web Serial API chooser dialogs which link to Chrome help center pages for these APIs. Bug: 1085149 Change-Id: Icbc619db8aeb18e87d6692e327d4ed9279076ab1

Chromium change: https://source.chromium.org/chromium/chromium/src/+/351d2d5c032fdae510d9286c51f646dd434bf4cd commit 351d2d5c032fdae510d9286c51f646dd434bf4cd Author: Robert Sesek <[email protected]> Date: Tue Feb 2 01:47:07 2021 +0000 Remove from mojo::DataPipe. All callers have been converted to to mojo::CreateDataPipe. Bug: 944990

…ocks SyncApiComponentFactoryMock is no longer available upstream, and FakeSyncApiComponentFactory should be used instead, along with some other smaller changes derived from other recent related changes upstream. This patch adapts the unit tests to maintain the same behaviour while using the new fake-based APIs, instead of the old ones. [TODO] BraveProfileSyncServiceTest.NoIdentityManagerCalls is not completely migrated yet, we still need to migrate mock-based check EXPECT_CALL(*engine(), OnCookieJarChanged(_, _)).Times(0) Chromium changes: https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac commit dcdd123f162664500d3976cdcb8e575ad8711bcf Author: Mikel Astiz <[email protected]> Date: Fri Jan 29 18:43:53 2021 +0000 [sync] Move SyncTransportDataPrefs closer to SyncEngineImpl These preferences represent the internal bookkeeping data that the implementation of the sync engine owns (SyncEngineImpl, backend, etc.), to be persisted in prefs. This patch moves the resposibility for dealing with prefs (reads and writes) from ProfileSyncService to SyncEngineImpl, simplifying some of of the APIs in between and adhering to more strict layering principles. Instead of moving all functionality in a single patch, the most relevant parts are moved, but TODOs are added to move the remaining parts and therefore completely avoid the dependency from ProfileSyncService to SyncTransportDataPrefs. Meanwhile, *both* ProfileSyncService and SyncEngineImpl interact with these preferences, which is obviously not great. Bug: 938894 commit 0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f Author: Mikel Astiz <[email protected]> Date: Fri Jan 29 12:52:21 2021 +0000 [sync] Avoid abuse of mocks in ProfileSyncService tests In particular the tests in ProfileSyncServiceStartupTest made heavy use of statefull mocks, well beyond a reasonable use of mocks. Instead, this patch adopts fakes that mimic the production behavior without tests having to carefully do so. For DataTypeManager, there is currently no fake, so instead the actual DataTypeManagerImpl is used, which is perfectly testable in combination with FakeDataTypeController. Bug: 938894 commit e60c93afaa485a6641ccd26222581626f74a7cac Author: Marc Treib <[email protected]> Date: Tue Jan 26 17:10:16 2021 +0000 Cleanup: Remove initial_types param from DataTypeManagerImpl's ctor The param was used to initialize the downloaded_types_ member, but that anyway got recomputed in ActivateDataTypes(), so the initial value had no effect. This CL removes the param, and all the plumbing that was in place for it. Note that there was one test which used the initial_types param, with the intention of marking these types as "already downloaded". The test passes before as after this CL. Fixing the test so that it actually tests what it claims to test is left as a followup. Bug: 1170318

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/d08ceac7afccb16fc18e8e29d05f6cb9e1c5043d Remove unused FeatureHighlightProvider.java Bug: 907617

Underlying chromium changes: https://chromium.googlesource.com/chromium/src.git/+/80470f550fd433ddea4193f304b7a99f76018664 Componentize BackgroundTaskUpdateScheduler under component_updater No change in logic, Just fleshing out BackgroundTaskUpdateScheduler out of chrome and move it under components/component_updater/android so that WebView can share the implementation with chrome. Bug: 1170729 https://chromium.googlesource.com/chromium/src.git/+/d4e5432328169a4fc6d2854b7ce65698b325e4a4 weblayer/android: move kAndroidAppScheme to components/embedder_support/android/common so that it can be used by both android and weblayer. BUG=none TEST=none

Added redirect-cc.exe that serves the same function as redirect-cc.cmd (calls python with redirect-cc.py script), but doesn't suffer from the "command line is too long" errors. Removed patches that were trying to get around command line length by writing MS includes into a file and then reading from it. Removed redirect-cc.cmd and code to copy it to out directory. Added redirect-cc.exe binary, source code (sln + vcxproj). Replaced cc-wrapper config with path to the exe binary.

…4412.3.

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/2d96608b432cb9c2e1b82ba11f73e07f95861f58 commit 2d96608b432cb9c2e1b82ba11f73e07f95861f58 Author: Alexei Svitkine <[email protected]> Date: Thu Feb 4 23:25:06 2021 +0000 Remove RAPPOR reporting infrastructure. Only a handful of metrics were still reported using this, which are have been confirmed to be OK to remove. Includes code to clear the obsolete rappor prefs. Bug: 1016906

The following Chromium change is causing an issue with Python3 on Win: https://chromium.googlesource.com/chromium/src/+/efdcb8407e0d9139e142aaf236cffb97b5e6d7f1%5E%21/#F0 It added the wheel for psutil 5.7.2 to .vpython3. But there doesn't appear to be a prebuilt wheel for the particular architecture (amd64_cp38_cp38m). Even when I try to use pip to install that version of psutil, pip downloads the source distribution and tries to build locally (which fails since we don't have python-dev installed) instead of grabbing a prebuilt package. With vpython3 get the following error: ________ running 'vpython3 script/download_rust_deps.py' in 'C:\bb4\brave-browser\src/brave' [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] original error: no such package: infra/python/wheels/psutil/windows-amd64_cp38_cp38m [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] goroutine 73: [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] #0 go.chromium.org/luci/cipd/client/cipd/client.go:1838 - cipd.(*clientImpl).humanErr() [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] #1 go.chromium.org/luci/cipd/client/cipd/client.go:816 - cipd.(*clientImpl).ResolveVersion() [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] #2 go.chromium.org/luci/cipd/client/cipd/resolver.go:176 - cipd.(*Resolver).resolveVersion.func1() [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] #3 go.chromium.org/luci/common/sync/promise/promise.go:84 - promise.(*Promise).runGen() [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] #4 runtime/asm_amd64.s:1374 - runtime.goexit() [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] goroutine 72: [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] From frame 0 to 0, the following wrappers were found: [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] internal reason: MultiError 1/1: following first non-nil error. [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] #0 go.chromium.org/luci/cipd/client/cipd/ensure/file.go:255 - ensure.(*File).Resolve.func1.1() [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] reason: failed to resolve infra/python/wheels/psutil/windows-amd64_cp38_cp38m@version:5.7.2 (line 0) [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] #1 go.chromium.org/luci/common/sync/parallel/runner.go:51 - parallel.(*WorkItem).execute() [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] #2 go.chromium.org/luci/common/sync/parallel/runner.go:149 - parallel.(*Runner).dispatchLoopBody.func2() [E2021-02-09T20:44:06.398243-05:00 32528 0 annotate.go:241] #3 runtime/asm_amd64.s:1374 - runtime.goexit() [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] goroutine 1: [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] #0 go.chromium.org/luci/vpython/venv/config.go:183 - venv.(*Config).makeEnv() [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] reason: failed to resolve packages [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] #1 go.chromium.org/luci/vpython/venv/venv.go:163 - venv.With() [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] #2 go.chromium.org/luci/vpython/run.go:62 - vpython.Run() [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] #3 go.chromium.org/luci/vpython/application/application.go:320 - application.(*application).mainImpl() [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] #4 go.chromium.org/luci/vpython/application/application.go:408 - application.(*Config).Main.func1() [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] #5 go.chromium.org/luci/vpython/application/support.go:46 - application.run() [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] #6 go.chromium.org/luci/vpython/application/application.go:407 - application.(*Config).Main() [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] #7 vpython/main.go:109 - main.mainImpl() [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] #8 vpython/main.go:115 - main.main() [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] #9 runtime/proc.go:204 - runtime.main() [E2021-02-09T20:44:06.399254-05:00 32528 0 annotate.go:241] #10 runtime/asm_amd64.s:1374 - runtime.goexit() Error: Command 'vpython3 script/download_rust_deps.py' returned non-zero exit status 1 in C:\bb4\brave-browser\src/brave ----- Also, see https://bugs.chromium.org/p/chromium/issues/detail?id=1141986

Chromium changes: https://chromium.googlesource.com/chromium/src.git/+/c56b5b62935046bbc3137fe7e202ee9e80035ab2 commit c56b5b62935046bbc3137fe7e202ee9e80035ab2 Author: Daniel Cheng <[email protected]> Date: Fri Feb 5 01:24:35 2021 +0000 [mojo] Remove most legacy Binding classes. AssociatedBinding is left as a followup, since AssociatedReceiver is implemented in terms of AssociatedBinding. Bug: 955171 https://chromium.googlesource.com/chromium/src.git/+/770cdcba6162c417af2e9700bf67e113903f99a1 commit 770cdcba6162c417af2e9700bf67e113903f99a1 Author: Daniel Cheng <[email protected]> Date: Thu Feb 4 23:10:54 2021 +0000 [mojo] Remove BindingSet helpers (replaced by *ReceiverSet equivalents). Bug: 955171

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/e9873df7cb167c263743645842763c7d2a48ed51 Android notification: NotificationInterceptor now considers request code. The original request code should be considered as well when computing the unique hash code for the wrapped PendingIntent in notification trampoline logging layer. Bug: 1174592

The class it patched is obsolete now upstream and does no longer exist. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/338735218df4b29ebef585b06b26a9822ad4400e commit 338735218df4b29ebef585b06b26a9822ad4400e Author: Elizabeth Popova <[email protected]> Date: Mon Feb 15 14:41:29 2021 +0000 [Android][Autofill] Remove server profile handling in Settings This CL cleans up the obsolete logic for dealing with server (AutofillProfile.RecordType == SERVER_PROFILE) profiles, which are no longer shown in Settings. Bug: 1177366

The affected code has been removed upstream, and we don't need to comment out that GN assertion anymore. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/338735218df4b29ebef585b06b26a9822ad4400e commit 338735218df4b29ebef585b06b26a9822ad4400e Author: Elizabeth Popova <[email protected]> Date: Mon Feb 15 14:41:29 2021 +0000 [Android][Autofill] Remove server profile handling in Settings This CL cleans up the obsolete logic for dealing with server (AutofillProfile.RecordType == SERVER_PROFILE) profiles, which are no longer shown in Settings. Bug: 1177366 Change-Id: If9e12decdfecddd93637d06a45bb298285600941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2684455 Reviewed-by: Friedrich [CET] <[email protected]> Reviewed-by: Boris Sazonov <[email protected]> Reviewed-by: Matthias Körber <[email protected]> Commit-Queue: Elizabeth Popova <[email protected]> Cr-Commit-Position: refs/heads/master@{#854039}

The GN target we were patching before has been split into different ones and we now need to move this patch to components/sync/engine/BUILD.gn. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/2275afee7febb3e7e40207d2e05b7ed1b68d9d78 commit 2275afee7febb3e7e40207d2e05b7ed1b68d9d78 Author: Victor Hugo Vianna Silva <[email protected]> Date: Mon Feb 8 15:02:16 2021 +0000 [sync] Split rest_of_sync build target into engine, model and nigori This CL builds on the work of crrev.com/c/{2652625,2659120} to finally split the rest_of_sync build target into smaller per-directory ones. A few changes worth noting: - Clean up some duplicates/self-deps entries in DEPS files, accidentally introduced in crrev.com/c/2659120. - Add one TODO about moving entity_data.h out of engine/, which should have been added in crrev.com/c/2652625. - Avoid one model/ include in base:test_support by moving the file with the include to the test_support_model target. - Remove unused dependencies //sql, //third_party/crc32c and //ui/base. - Move from private to public dependency: * //components/signin/public/identity_manager (AccountInfo used in SyncEngine public API). * //services/network/public/cpp (used in HttpBridge & SyncManagerImpl public APIs). - Keep the precompiled_headers build config only for targets with >50 .cc files [1]. This means adding it to engine/ and removing it from base/, driver/ and protocol/. [1] https://source.chromium.org/chromium/chromium/src/+/3abc98c09a9174a91f82e6f2eccf0ebb6c203fdf:build/config/BUILD.gn;l=375 [email protected] Bug: 947443

… list. Plugin types have been removed from upstream and the patch needs to be slightly adapted now. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/6eff34f62979302e815f2bb17d84267d5fb32d5a commit 6eff34f62979302e815f2bb17d84267d5fb32d5a Author: Antonio Sartori <[email protected]> Date: Thu Feb 11 10:24:22 2021 +0000 Remove plugin-types from CSP extension validator The Content Security Directive 'plugin-types' is being removed from the CSP code. This CL removes pieces of code in the CSP extension validator that were referring to 'plugin-types'. More in detail, the CSP extension validator was blocking component extensions which allow plugins from insecure sources but do not specify a Content Security Policy restricting the allowed plugins, blocking Flash. Note that with the removal of Flash, this is not really needed anymore. Since the 'plugin-types' directive is going to be removed, we are cleaning up the CSP extension validator, too. Bug: 1168001

…essor The surrounding code has changed slightly upstream. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/e91e6c2e52a71c9de0841c5d7322d9e90255ee0f commit e91e6c2e52a71c9de0841c5d7322d9e90255ee0f Author: Jinsuk Kim <[email protected]> Date: Tue Feb 9 01:32:56 2021 +0000 Omnibox: Remove the usage of ActivityTabProvider Defines a new interface method in LocationBarDataProvider that gets triggered by the same condition (switching to an NTP) instead. Bug: 1171512

We need to adapt the patch to friend BraveWalletService with that class and then adapt BraveWalletService to use the right methods. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/a115a7598e5a0ff970e17e36624c1b5ead70049b commit a115a7598e5a0ff970e17e36624c1b5ead70049b Author: Kelvin Jiang <[email protected]> Date: Thu Feb 11 03:04:01 2021 +0000 [Extensions] Use one UserScriptManager class for all user scripts This CL merges DeclarativeUserScriptManager and ExtensionUserScriptManager into: UserScriptManager (USM). USM is owned by the ExtensionSystem. A USM was also added to the TestExtensionSystem. Bug: 1168627

…rocess() The place we need to patch has now moved from there to the private helper function LaunchWithoutSandbox(), where we don't have access to the string with the process type. Therefore, we need to adapt slightly the helper in the chromium_src override and move the place it's called from. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/92757d2ff56133de2a8999d8327d5d108f632565 commit 92757d2ff56133de2a8999d8327d5d108f632565 Author: Alex Gough <[email protected]> Date: Thu Feb 11 01:02:37 2021 +0000 Refactor unsandboxed process launching. No functional changes. I intend to expand this helper function to cope with CETCOMPAT. This refactor makes it clearer that this path is taken and does not continue into the rest of the sandboxed flow. Bug: 1174399

These were being transitively included before, but need to be explicitly added now.

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/04aab368aa7c0bf0f5d78e099fda8e0c2cf1ee26 commit 04aab368aa7c0bf0f5d78e099fda8e0c2cf1ee26 Author: Carlos Caballero <[email protected]> Date: Mon Feb 15 17:38:16 2021 +0000 Remove Navigator::GetController Navigator::controller can be used instead. Bug: 1170277

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/cb5cbcb9f8d88ff6e1a108bf9623e8372c72fd2f commit cb5cbcb9f8d88ff6e1a108bf9623e8372c72fd2f Author: Dave Tapuska <[email protected]> Date: Tue Feb 9 19:10:45 2021 +0000 Move OnSSLCertificateError to a new interface. Add a new AuthenticationAndCertificateObserver mojo interface as detailed in [1]. This interface is created to be bound by a frame or a navigation request. The interface is still implemented in the StoragePartitionImpl. Rename AuthenticationHandler to WebSocketAuthenticationHandler so that it is clear that interface is only for WebSockets. Change WebSocket interface to take a bound AuthenticationAndCertificateObserver and remove the passed in frame id. [1] https://tinyurl.com/yshosfw9 Bug: 1173710

The NOTIFICATION_PROFILE_CREATED type is gone upstream, and the way to listen to similar events now is via ProfileManagerObserver and its OnProfileAdded() method, so let's migrate the only two cases to that. Added testing profile manager to BraveStatsUpdaterTest unit tests since they create Brave Ads profile which depends on the rewards service, which observes profile manager. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/b04af9656279990aef62e184973658bd1002ccfb commit b04af9656279990aef62e184973658bd1002ccfb Author: Alex Ilin <[email protected]> Date: Mon Feb 15 13:05:19 2021 +0000 [profiles] Remove NOTIFICATION_PROFILE_CREATED As part of the notification system deprecation, this CL removes NOTIFICATION_PROFILE_CREATED. This notification type is only used in tests that can observe ProfileManager instead. To share the test observer between tests, a new ProfileWaiter class is added to chrome/test/base. Bug: 1174786

The new PermissionKeyForRequestType() helper function adds a switch statement for permissions::RequestType, so we need to add the case for kWidevine, which we manually added via a chromium_src override. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/3f64b41ed5152e36b6e685353fdb4a28ea5d8b0a commit 3f64b41ed5152e36b6e685353fdb4a28ea5d8b0a Author: Andy Paicu <[email protected]> Date: Mon Feb 8 10:28:02 2021 +0000 Create a centralized class for interacting with permission actions... ...historical data crrev.com/c/2526681 added a new client for permission action historical data which duplicated some logic. This CL dedupes that logic, and also adds support for counting all previous actions, not just notifications. 1) PermissionActionsHistoricData is a KeyedService containing utility functions to interact with the permission actions history. It's expanded handle all action types not just notifications. 2) AdaptiveQuietNotificationPermissionUiEnabler now interfaces with this class and does not hold any logic except strictly for enabling the quiet notifications ui adaptively. 3) PredictionBasedPermissionUiSelector now also interfaces with this class, ensuring there is no more duplicate logic. 4) Since the history is now needed elsewhere, the adaptive activation will stop deleting history when the quiet ui is manually disabled. Instead a new pref holds the time at which it was disabled, and the adaptive activation only considers actions after said time. 5) The separate clock instance that was used for testing was removed in favor of using a task environment with the TimeSource::MOCK_TIME trait. Bug: 1138595

This has now been moved to content::WebUIDataSource. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/f61285cb336a171497c2edc2355a099aba983dba commit f61285cb336a171497c2edc2355a099aba983dba Author: dpapad <[email protected]> Date: Tue Feb 9 21:56:39 2021 +0000 Move webui::AddLocalizedStringsBulk to content::WebUIDataSource. Previously it was implemented as a helper function in webui_util.cc, but it better belongs in WebUIDataSource as an instance method. With this change, several calls like webui::AddLocalizedStringsBulk(source, kLocalizedStrings); are converted to source->AddLocalizedStrings(kLocalizedStrings); A concrete benefit of moving this method in WebUIDataSource is that it now can be leveraged by more places in the code (for example chromeos/components/), which do not have permission to depend on chrome/. This is in preparation of moving more webui_util.cc helpers into WebUIDataSource (for similar reasons), and eventually possibly converting SharedResourcesDataSource to a WebUIDataSource as well. Bug: 1176299

This method has been removed from upstream as it was not used and there does not seem to be an equivalent one available, so let's bring it back. Fixup! Mario says: on a second thought I think this is probably not needed so reverting this change (and simply dropping the CloseGuestProfileWindows() call from BraveProfileMenuView::OnExitProfileButtonClicked(). Chromium change: https://chromium.googlesource.com/chromium/src.git/+/53d0699ee2609b7195a93d92d2433500a0affd55 commit 53d0699ee2609b7195a93d92d2433500a0affd55 Author: Monica Basta <[email protected]> Date: Wed Feb 10 11:57:07 2021 +0000 [Profiles]: Avoid opening the profile picker on close 'x' windows Currently on click on 'Close x windows' from the profile menu, the profile is closed and the user manager/profile picker is opened. This behavior is no longer desired. Clicking on the button should only close the profile. This CL also removes 'CloseGuestProfileWindows' function that is not used. Bug: 1176599

Adapt Brave-specific code and overrides to use this equivalent struct. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/a696151783d69bc6e8884246418d771d06cd9f53 commit a696151783d69bc6e8884246418d771d06cd9f53 Author: dpapad <[email protected]> Date: Tue Feb 16 12:34:08 2021 +0000 WebuI: Delete GritResourceMap struct in favor of webui::ResourcePath. - Move webui::ResourcePath definition to its own file in ui/base/webui/. - Modify Grit to use webui::ResourcePath, and delete the identical GritResourceMap struct. - Remove the AddResourcePathsBulk() override that used GritResourceMap. This is in preparation of moving AddResourcePathsBulk to WebUIDataSource itself. Bug: 1176299

As per `brave/chromium_src/components/permissions/request_type.cc` kWidevine is not defined for Android and iOS.

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/f3add8f687acb2ddff2d0c567cfa768a0f9b3bbd Remove Feedv1 code Much of this code was already compiled-out. Some exceptions: - Code branches with if (v1 enabled) { ... } were removed. - Extracted functions from v1 library LocateUtils class into FeedServiceBridge. - Some code in components/feed wasn't yet removed from the build, but wasn't referenced, and is now removed. - Shared proto databases for v1 were added to kObsoleteSharedProtoDbTypeClients - Obsoleted v1 specific prefs. Bug: 1165828

Fixes brave/brave-browser#14217 Chromium changes: https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac

It is no longer needed: when necessary resource_path can be used in the grd. Chromium change: https://bugs.chromium.org/p/chromium/issues/detail?id=1171239 https://source.chromium.org/chromium/chromium/src/+/48b1ba996d2e019abad844fc47a5a1710b9da737 commit 48b1ba996d2e019abad844fc47a5a1710b9da737 Author: dpapad <[email protected]> Date: Mon Feb 8 21:10:42 2021 +0000 WebUI: Remove aliasing mechanism in SharedResourcesDataSource The last few entries in the alias map were either 1) Unnecessary because the URLs were no longer used (views/resources/ case) 2) Unnecessary because they could be replaced with |resource_path| (lottie case)

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/8af3e56abb81a251b481fdb2bb38ea980629ea07 commit 8af3e56abb81a251b481fdb2bb38ea980629ea07 Author: Richard Knoll <[email protected]> Date: Wed Feb 10 03:01:34 2021 +0000 Move macOS notification constants and utils to service Mechanical change so we can use the same constants and helper methods in the notification service process. Bug: 1170731

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/b6ef036c4ec54c16c9621eab44d1dbbf2c8df001 commit b6ef036c4ec54c16c9621eab44d1dbbf2c8df001 Author: Jesse McKenna <[email protected]> Date: Mon Feb 8 18:25:48 2021 +0000 breadcrumbs: componentize BreadcrumbManager This change is a step toward bringing breadcrumbs (currently iOS-only to desktop by making it a layered component. BreadcrumbManager's two dependencies (constants and BreadcrumbManagerObserver) have already been componentized, so upstreaming it is straightforward. Unit tests will be migrated later, after the bulk of the migration is finished. Bug: 1163762

It is not used in Brave. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/4fe26992804b69705462de5df53d948e86e39b64 Enable Feed V2 by default, and change the default stale content threshold. Bug: 1175952

…4427.5.

Chromium change: https://source.chromium.org/chromium/chromium/src/+/19bd6c6cc41a4e5f41a61a8acb88e0337763e733 commit 19bd6c6cc41a4e5f41a61a8acb88e0337763e733 Author: Matt Stark <[email protected]> Date: Wed Feb 17 08:47:48 2021 +0000 Replace fake-bidi with the pseuduolocales en-XA and ar-XB These pseudolocales have better translations, are not broken, and have a consistent naming scheme with android pseudolocales. BUG=chromium:1173812

Grit is not happy with the {{}} placeholders. Why are we not just using <ph>? Error processing node <?xml version="1.0" encoding="UTF-8"?> <message name="IDS_BRAVE_PRIVATE_NEW_TAB_BOX_TOR_TEXT_2"> Using Private Windows only changes what Brave does on your device — it doesn't change anyone else's behavior. Tor hides your IP address from the sites you visit, and hides the sites you visit from your ISP or your employer. Open a Private Window with Tor from the menu, or with {{ key }}. </message>: {{ key }}. Traceback (most recent call last): File "../../tools/grit/grit.py", line 29, in <module> sys.exit(grit.grit_runner.Main(sys.argv[1:])) File "C:\bb4\brave-browser\src\tools\grit\grit\grit_runner.py", line 314, in Main return toolobject.Run(options, args[1:]) File "C:\bb4\brave-browser\src\tools\grit\grit\tool\build.py", line 274, in Run self.Process() File "C:\bb4\brave-browser\src\tools\grit\grit\tool\build.py", line 409, in Process self.ProcessNode(self.res, output, tmpfile) File "C:\bb4\brave-browser\src\tools\grit\grit\tool\build.py", line 333, in ProcessNode formatted = formatter(node, output_node.GetLanguage(), output_dir=base_dir) File "C:\bb4\brave-browser\src\tools\grit\grit\format\data_pack.py", line 90, in Format value = node.GetDataPackValue(lang, util.BINARY) File "C:\bb4\brave-browser\src\tools\grit\grit\node\message.py", line 288, in GetDataPackValue message = self.ws_at_start + self.Translate(lang) + self.ws_at_end File "C:\bb4\brave-browser\src\tools\grit\grit\node\message.py", line 270, in Translate self.ShouldFallbackToEnglish() File "C:\bb4\brave-browser\src\tools\grit\grit\clique.py", line 406, in MessageForLanguage return pseudolocales.PseudoRTLMessage(self.GetMessage()) File "C:\bb4\brave-browser\src\tools\grit\grit\pseudolocales.py", line 323, in PseudoRTLMessage tree, placeholders = BuildTreeFromMessage(message) File "C:\bb4\brave-browser\src\tools\grit\grit\pseudolocales.py", line 271, in BuildTreeFromMessage return BuildTree(text), placeholders File "C:\bb4\brave-browser\src\tools\grit\grit\pseudolocales.py", line 255, in BuildTree assert not leftovers, leftovers AssertionError: {{ key }}.

Followups may be needed to hide what we don't need in the redesigned Settings UI. Chromium change: https://chromium.googlesource.com/chromium/src/+/c696884758797f79b6701450100f003d91ecd653 commit c696884758797f79b6701450100f003d91ecd653 Author: Sean Harrison <[email protected]> Date: Fri Feb 19 17:08:20 2021 +0000 [WebUI] Remove old PrivacySettingsRedesign flag PrivacySettingsRedesign has been launched for a while, this cleans up any remaining usage of the flag. Bug: 1032584

Chromium change: https://source.chromium.org/chromium/chromium/src/+/1b46c0a5122001153c56824f024a68ba56e5d1f9 commit 1b46c0a5122001153c56824f024a68ba56e5d1f9 Author: Keishi Hattori <[email protected]> Date: Mon Feb 22 22:02:34 2021 +0000 Fix BrowserNavigatorTest.SwitchToTabIncognitoLeak for BackupRefPtr BrowserNavigatorTest.SwitchToTabIncognitoLeak fails when BackupRefPtr is used because it reads NavigateParams:: rowser after it has been moved. Unlike raw pointer, BackupRefPtr will be cleared when moved. This CL changes ShowSingletonTabOverwritingNTP() to take a pointer so Navigate() doesn't have to move NavigateP rams.

Should use ProfilePicker now. Chromium change: https://chromium.googlesource.com/chromium/src/+/f3c2c8d2fff648ef78f520f823aeaae48ac7ec4c commit f3c2c8d2fff648ef78f520f823aeaae48ac7ec4c Author: Monica Basta <[email protected]> Date: Mon Feb 22 18:21:01 2021 +0000 [UserManager]: Remove the user manager code. The User manager is being replaced with the new profile picker. This CL deletes the user manager code. Bug: 1014322

Chromium change: https://source.chromium.org/chromium/chromium/src/+/3bce5dd0e62e636614521b902e26fb47070e18c9 commit 3bce5dd0e62e636614521b902e26fb47070e18c9 Author: Robert Sesek <[email protected]> Date: Fri Feb 19 19:27:58 2021 +0000 mojo: Remove deprecated CreateDataPipe overload that takes pointer out-args Bug: 944990

Chromium change: https://chromium.googlesource.com/chromium/src/+/a718ebd25a45e1265165c8a492c086b106ba7fbe commit a718ebd25a45e1265165c8a492c086b106ba7fbe Author: John Delaney <[email protected]> Date: Thu Feb 18 22:26:36 2021 +0000 Remove NOTIFICATION_WEB_CONTENTS_DISCONNECTED Replaces existing instances with WebContentsObserver::WebContentsDestroyed() and/or WebContentsObserver::RenderProcessGone() and removes the notification invocation. Bug: 1174766

Chromium change: https://source.chromium.org/chromium/chromium/src/+/db01f8a5783095aee1de20925fb8cc4d67f6c485 commit db01f8a5783095aee1de20925fb8cc4d67f6c485 Author: Anthony Cui <[email protected]> Date: Thu Feb 18 21:45:18 2021 +0000 Refactor unknown source language option and add support to Android This change - Refactors the implementation of the Unknown source language option, adding it at the TranslateUIDelegate level and treating it like other language options - Renames the "Unknown" option to "Detected Language" for a more functional description - Adds support for use of the new "Detected Language" source language option on Android - Adds both the string change and the Android support changes behind a new feature flag Bug: 1127094

A new static assertion has been added upstream and otherwise the build will fail for Linux now, as well as for other platforms in the next release. Chromium change: https://source.chromium.org/chromium/chromium/src/+/ad0da8ebec488b6b3696b44d2da80744f8a90d17 https://source.chromium.org/chromium/chromium/src/+/63714a9ffe267a0212f4120a188f45408555a993 commit ad0da8ebec488b6b3696b44d2da80744f8a90d17 Author: Daniel Cheng <[email protected]> Date: Mon Feb 22 21:07:22 2021 +0000 Disallow base::Passed() from being used with base::BindOnce(). The assert is currently only enabled on OS_LINUX. Platforms will be incrementally fixed until the assert is enabled everywhere. Bug: 1180750 commit 63714a9ffe267a0212f4120a188f45408555a993 Author: Daniel Cheng <[email protected]> Date: Fri Feb 26 09:51:28 2021 [base] Disallow base::BindOnce() + base::Passed() use on iOS. std::move() and base::Passed() mean the same thing for base::BindOnce(), so use the standard library idiom instead. Bug: 1180750

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/0409372615dde3d990738a730b6f784d695bf678 [Build] Switch androidx dependencies to use //third_party/androidx This CL switches depenendencies on the //third_party/android_deps:androidx alias to refer to //third_party/androidx instead. This CL was generated via: find . -name *.gn -exec sed -i 's/android_deps:androidx/androidx:androidx/g' {} + BUG=1064277

Chromium change: https://source.chromium.org/chromium/chromium/src/+/20a41c8b03a9ab035619e225520dfec484fb3e69 commit 20a41c8b03a9ab035619e225520dfec484fb3e69 Author: Glen Robertson <[email protected]> Date: Tue Jan 19 08:20:35 2021 +0000 Separate profile.{cc,h} (& observer) to its own GN target. This allows other code to depend on profile.h (very common as it is a keyed service key) without depending on all of //c/b:browser. This improves modularization of the codebase and will help to break dependency cycles in GN. Bug: 1149277

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/d089c588065dd2f12fe17d9d10b4e1fbbb1c5e20 Move TileView to components/browser_ui/widget Moving TileView related class to components/browser_ui/widget, and all related resources files to make it available for using in launchpad module. Bug: 1178919

Chromium changes: https://source.chromium.org/chromium/chromium/src/+/4737f9a9625b17bbe7b8d3387823c8eef84f6d2b commit 4737f9a9625b17bbe7b8d3387823c8eef84f6d2b Author: Richard Knoll <[email protected]> Date: Thu Jan 21 12:52:59 2021 +0000 Remove NotificationCenter from AlertDispatcher This refactors the macOS AlertDispatcher interface to no longer require an instance of NSUserNotificationCenter to be passed in. We expect the caller to query their local NotificationCenter instead and merge the results. This allows us to use the same interface in a future CL for the UNNotification API. Bug: 1127306 https://source.chromium.org/chromium/chromium/src/+/b8acb518aba0a01f6a14dfc6d32715671f3d8cdd commit b8acb518aba0a01f6a14dfc6d32715671f3d8cdd Author: Richard Knoll <[email protected]> Date: Mon Jan 25 12:07:21 2021 +0000 Reland "Pass incognito flag when closing macOS alerts" This is a reland of e48554ec4a6e3c50fb63717edb0a0d244a98616c The original change revealed that the currently used API has the same issue when identifying notifications from multiple profiles. It only used the notification id as identifier which might clash with another Chrome profile. This is now fixed by using the same unique identifier we use for the new API. PS1 contains the original change PS2 has the fix for the currently used API Original change's description: > Pass incognito flag when closing macOS alerts > > A macOS notification is identified with the tuple > {notificationId, profileId, incognito} and we have to pass these down to > the XPC service to close the correct notification. The same applies to > the notification id used in the UNNotification API where we need to > include the incognito flag in the id. Also updates some method names to > be more consistent. > > Bug: None > Change-Id: Ie45cb74eab182e0b495560110d8e6e32367c4bc7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642275 > Reviewed-by: Rayan Kanso <[email protected]> > Commit-Queue: Richard Knoll <[email protected]> > Cr-Commit-Position: refs/heads/master@{#846183} Bug: None https://source.chromium.org/chromium/chromium/src/+/dd062faf6b1bf61d0410b1e0ab52afb42215b1b2 commit dd062faf6b1bf61d0410b1e0ab52afb42215b1b2 Author: Richard Knoll <[email protected]> Date: Tue Feb 2 13:03:55 2021 +0000 Get all alerts shown via XPC on macOS This adds a new method to the XPC service that allows us to get all currently displayed alert notifications regardless of which profile they belong to. This will be required in the new bridge as the UNNotification API has no reliable way of detecting when a notification has been dismissed. Instead we will periodically synchronize with the system to detect closed notifications like we do on Windows 10. Bug: 1134570 https://source.chromium.org/chromium/chromium/src/+/efcf97ea2b47844b017fe95d4cb349eaf97d6d9c commit efcf97ea2b47844b017fe95d4cb349eaf97d6d9c Author: Richard Knoll <[email protected]> Date: Fri Feb 26 00:35:32 2021 +0000 Close macOS notifications on profile shutdown We need to close notifications earlier in the shutdown process as it's too late to do so in the destructor. Closing them in the profile shutdown method also makes sense as we don't want notifications for incognito or guest profiles to stay around. Bug: 1170731

…4430.11.

Chromium change: https://chromium.googlesource.com/chromium/src/+/c30c9ddff5c96efd8e2455d7435e49806526c155 commit c30c9ddff5c96efd8e2455d7435e49806526c155 Author: Peter Beverloo <[email protected]> Date: Wed Feb 24 19:56:03 2021 +0000 Introduce "system notifications" terminology to mirror the native ones This is the first step in migrating from "native notifications" to "system notifications", following the spirit of inclusive code. A very brief migration plan has been included in the linked issue. Concretely, this CL: * Introduces the SystemNotifications base::Feature, matching the NativeNotifications one. Both will be supported for one milestone. * Introduces the AllowSystemNotifications enterprise policy, matching the AllowNativeNotifications one. Both will be supported for about a year, enabling enterprises to migrate. * Updates the chrome://flags entry to say "system notifications" and set the new base::Feature flag. * Renames the build-time flag, as deprecation concerns are pretty much absent there. Bug: 1136840

Chromium change: https://source.chromium.org/chromium/chromium/src/+/a777eed95997da8fc833a0ef2c81f4ed7893fd99 commit a777eed95997da8fc833a0ef2c81f4ed7893fd99 Author: Yngve N. Pettersen <[email protected]> Date: Wed Feb 24 16:04:55 2021 +0000 Removed unused constants from chrome_constants.cc

Chromium change: https://source.chromium.org/chromium/chromium/src/+/baf0ae47d7e2cf02e275189aa4a7d47e455de42a commit baf0ae47d7e2cf02e275189aa4a7d47e455de42a Author: Greg Thompson <[email protected]> Date: Thu Feb 25 21:25:27 2021 +0000 Reverse the polarity of IsNonBrowserProcess. IsBrowserProcess is more readable. Bug: None

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/c19bb6cc36a9f43590b44a08eccc913994850c5c Initial support for camera assisted search with Google Lens in Omnibox and NTP Design doc:go/lens-chrome-omnibox-ntp Screenshot: https://screenshot.googleplex.com/5idKZZSfmGxs6ca Change-Id: Ie799e6186e806d0a21d6f0f17bf83c66bfb242ea Bug: 1175230,b/180518516

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/4531669c4a190ce699ca78c2861a03941159a3d3 Roll ARCore SDK & APK to version 1.22

Makes GetPlaceholderAvatarIconWithColors return our placeholder avatar instead of the Chromium "person" avatar. Chromium change: https://source.chromium.org/chromium/chromium/src/+/c68aba965e4a0f8af3fda63c636cc743babcee85 commit c68aba965e4a0f8af3fda63c636cc743babcee85 Author: Monica Basta <[email protected]> Date: Wed Feb 24 15:10:36 2021 +0000 [Spaces]: Enable colored generic avatars by default. With the profile picker replacing the user manager, the current profile creation flow has the generic colored avatars. It makes sense to keep showing the colored generic avatar not the grey one in the UI. Bug: 1014322

…bels The override was inserting the default avatar into list so it was visible in the Settings profile webui and profile picker. We no longer need to do that because the webui does it on its own now. Chromium change: https://source.chromium.org/chromium/chromium/src/+/fdfc1bb686334d8861d62d45f9b5246225cea41d commit fdfc1bb686334d8861d62d45f9b5246225cea41d Author: Monica Basta <[email protected]> Date: Thu Feb 25 19:40:50 2021 +0000 [Settings]: Remove the code of the old design of manage profiles page. The profile picker is replacing the current user manager for M90. As a consequence the new local profile creation flow will be the only UI used for profile creation. Newly created profiles will have the option to use the generic colored avatar as well as a theme color. Therefore, using the new design for the manage profile is required for M90. Bug: 1014322

- Removes background images in the main view - Hides background image in the profile customization view - Fixes Add button border radius.

On MacOS: Undefined symbols for architecture x86_64: "vtable for FakeSystemGeolocationPermissionsManager", referenced from: TestingBrowserProcessPlatformPart::TestingBrowserProcessPlatformPart() in libtest_support.a(testing_browser_process_platform_part.o) NOTE: a missing vtable usually means the first non-inline virtual member function has no definition. ld: symbol(s) not found for architecture x86_64 Chromium change: https://source.chromium.org/chromium/chromium/src/+/63eb7e0f2322359ca1214224c346ad02f5e0264e commit 63eb7e0f2322359ca1214224c346ad02f5e0264e Author: James Hollyer <[email protected]> Date: Wed Feb 24 03:02:40 2021 +0000 Don't use Core Location after update After an update the binary on the disc is different from the one in memory until restart. While in this state if Core Location is accessed macOS removes location permission. We are currently only using Core Location to check for current permission status. This fix consolidates the permission state manager to a single object that is created and owned by the BrowserProcess. This status is cached in that object and accessed when needed throughout the application. The CoreLocationProvider is currently behind a flag that is disabled by default. More work is needed to ensure that class does not access Core Location while in a broken signed state before that flag can be enabled. Bug: 1143807

….4430.19.

…tService We don't use ExtensionRegistryObserver and simply access the private methods OnExtensionLoaded()/OnExtensionUnloaded() from UserScriptLoader instead since we only want to load/unload the content scripts and not the extension.

Profile Picker is shown under System profile (OTR), so when adding brave Brave shared resources to profiles we need to account for OTR profiles.

Function in web_ui_util.cc is no longer used to get the text_defaults_md.css resource for shared resources. Keep our override for the function resouce because it's still used in several places. Additionally, copy over our text_defaults_md.css via util.js so that it's used when chromium GRD is auto generated. Chromium change: https://source.chromium.org/chromium/chromium/src/+/ba11d6dc4a110c2c456eb453b445832847230b5e commit ba11d6dc4a110c2c456eb453b445832847230b5e Author: dpapad <[email protected]> Date: Wed Feb 24 18:26:57 2021 +0000 WebUI: Replace SharedResourcesDataSource with a regular WebUIDataSource. SharedResourcesDataSource was a custom class directly subclassing URLDataSource (and used for serving chrome://resources URLs). By doing so it included a lot of duplicated functionality for code that is already available in regular WebUIDataSourceImpl subclasses, for example - Registering resources - Registering loadTimeData strings - Calculating mime types based on a path's extension - Locating and serving WebUI files from pak files - Overriding specific CSP policies By using a regular WebUIDataSourceImpl a lot of duplicated code is deleted. Moreover, WebUIDataSourceImpl is a more mature class, that is heavily used across WebUI. For example this CL helped discover a bug where $i18n{...} string placeholders where incorrectly used in cr_components/ (fixed at r854879) because of CHECK()s that did not exist in SharedResourcesDataSource. In order to support chrome://resources/css/text_defaults.css $i18n{...} replacements, web_ui_url_loader_factory.cc has been modified to perform $i18n{...} replacements in CSS files too (previously only done for HTML files, and conditionally for JS files). Bug: 1179207

Removed checked in executable and added code to build it during the build process using MSBuild.

….4430.30.

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/4781613e02f1769063960ece12181bc1463f7a01 [Start] Update triggerUrlFocusAnimation logic. Before this CL, when calling triggerUrlFocusAnimation(), the value of |hasFocus| is set as |!urlHasFocus()| sometimes, which is not easy to understand. This CL makes the logic more understandable and keeps toolbar expanded on start surface homepage. (cherry picked from commit 2effd41efd4d2e06a571f03f96bec7e3dea88e95) Bug: 1184865

Chromium change: https://chromium.googlesource.com/chromium/src/+/d00f800f7d6372decfce0f897c54bab3e43e99b1 commit d00f800f7d6372decfce0f897c54bab3e43e99b1 Author: Victor Hugo Vianna Silva <[email protected]> Date: Mon Feb 1 15:18:45 2021 +0000 [Sync Model/Engine split] Merge {model,engine}_impl with {model,engine} The distinction between the impl and non-impl directories has become unclear over time, as well as the dependencies between them. This CL merges them. This will allow us to create separate build targets for engine/ and model/ (model/ depends on engine/). Subdirectories are merged correspondingly, e.g. engine_impl/cycle/ is merged with engine/cycle/. Orthogonal to this, we remove 1 unnecessary engine/ dependency from components/password_manager/core/browser/DEPS, and make some net/ dependencies more specific in sync/ DEPS. Bug: 947443

Chromium change: https://chromium.googlesource.com/chromium/src/+/5785d182ede480e644e3641adc38ed3502e42ad9 commit 5785d182ede480e644e3641adc38ed3502e42ad9 Author: Chris Thompson <[email protected]> Date: Fri Feb 19 01:39:46 2021 +0000 Reland "Reland "Remove TLS deprecation config"" This is a reland of 5c5a72b5885be681facb28e8c353bafb7eea445e This disables the affected tests on macOS. See crbug.com/1176880 for details. Original change's description: > Reland "Remove TLS deprecation config" > > This is a reland of fa522465a7821267f8618d978b2bf257730808a9 > > The original CL was reverted because it broke WSS tests on the Mac 10.11 > bot (due to old OpenSSL versions). This updated reland fixes the affected > tests. > > Original change's description: > > Remove TLS deprecation config > > > > As the control sites list is no longer used, this CL removes the > > deprecation config and control site suppression logic. Removing the > > deprecation config also causes some test cases to now default to > > preventing TLS 1.0/1.1 connections (as previously the enforcement > > intentionally failed-open if there was no deprecation config present) -- > > this removes tests that are no longer meaningful after this change, and > > updated other affected tests. > > > > Bug: 1039756

super.onPauseWithNative should be called only once

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade from Chromium 89 to Chromium 90. #7866

Upgrade from Chromium 89 to Chromium 90. #7866

Commits on Mar 23, 2021