Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chromium90] redo BraveProfileSyncServiceTest.NoIdentityManagerCalls test #14217

Closed
AlexeyBarabash opened this issue Feb 17, 2021 · 1 comment
Closed

[Chromium90] redo BraveProfileSyncServiceTest.NoIdentityManagerCalls test #14217

AlexeyBarabash opened this issue Feb 17, 2021 · 1 comment
Assignees
@AlexeyBarabash
Labels
closed/no-milestone OS/Desktop QA/No release-notes/exclude

Comments

@AlexeyBarabash
Copy link
Contributor

From conversation with @mariospr

Long story short: the SyncApiComponentFactoryMock and MockSyncEngine are gone now, and we need to adapt some of your recent unit tests.

I did migrate everything so far with one exception, this bit:
brave/brave-core@d114720#diff-d1c885c1e8cf38ee3de38b5d0%5B%E2%80%A6%5Dca715bd818e21bcebfb016f5328R178
Since the mock is no longer available, I'm not sure how to rewrite that indirect test you wrote there

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
@AlexeyBarabash AlexeyBarabash self-assigned this Feb 17, 2021
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Feb 17, 2021
@AlexeyBarabash
Test for BraveIdentityManager::GetAccountsInCookieJar
569520d 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
@AlexeyBarabash AlexeyBarabash mentioned this issue Feb 17, 2021
Merged
23 tasks
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Feb 21, 2021
@AlexeyBarabash
Test for BraveIdentityManager::GetAccountsInCookieJar
f7cdf56 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Feb 23, 2021
@AlexeyBarabash
Test for BraveIdentityManager::GetAccountsInCookieJar
dc0a331 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
mariospr pushed a commit to brave/brave-core that referenced this issue Feb 23, 2021
@AlexeyBarabash @mariospr
Test for BraveIdentityManager::GetAccountsInCookieJar
50e2b14 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
mkarolin pushed a commit to brave/brave-core that referenced this issue Feb 24, 2021
@AlexeyBarabash @mkarolin
Test for BraveIdentityManager::GetAccountsInCookieJar
db487f3 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
mkarolin pushed a commit to brave/brave-core that referenced this issue Feb 26, 2021
@AlexeyBarabash @mkarolin
Test for BraveIdentityManager::GetAccountsInCookieJar
3145bb9 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
mkarolin pushed a commit to brave/brave-core that referenced this issue Mar 4, 2021
@AlexeyBarabash @mkarolin
Test for BraveIdentityManager::GetAccountsInCookieJar
c27bce0 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
mkarolin pushed a commit to brave/brave-core that referenced this issue Mar 5, 2021
@AlexeyBarabash @mkarolin
Test for BraveIdentityManager::GetAccountsInCookieJar
64d83a2 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
mariospr pushed a commit to brave/brave-core that referenced this issue Mar 8, 2021
@AlexeyBarabash @mariospr
Test for BraveIdentityManager::GetAccountsInCookieJar
6c03afd 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
mkarolin pushed a commit to brave/brave-core that referenced this issue Mar 10, 2021
@AlexeyBarabash @mkarolin
Test for BraveIdentityManager::GetAccountsInCookieJar
c4fbc0d 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
mkarolin pushed a commit to brave/brave-core that referenced this issue Mar 10, 2021
@AlexeyBarabash @mkarolin
Test for BraveIdentityManager::GetAccountsInCookieJar
2ada77b 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
mkarolin pushed a commit to brave/brave-core that referenced this issue Mar 12, 2021
@AlexeyBarabash @mkarolin
Test for BraveIdentityManager::GetAccountsInCookieJar
5fe13eb 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
mariospr pushed a commit to brave/brave-core that referenced this issue Mar 15, 2021
@AlexeyBarabash @mariospr
Test for BraveIdentityManager::GetAccountsInCookieJar
e5fd94a 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
@AlexeyBarabash
Copy link
Contributor Author

Closed with PR brave/brave-core#7973

mkarolin pushed a commit to brave/brave-core that referenced this issue Mar 23, 2021
@AlexeyBarabash @mkarolin
Test for BraveIdentityManager::GetAccountsInCookieJar
1d92234 
Fixes brave/brave-browser#14217

Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/dcdd123f162664500d3976cdcb8e575ad8711bcf
https://chromium.googlesource.com/chromium/src.git/+/0ff6cfd2ae2f17dd8f99ae09f04b0fb24fd2a09f
https://chromium.googlesource.com/chromium/src.git/+/e60c93afaa485a6641ccd26222581626f74a7cac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
closed/no-milestone OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexeyBarabash