Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update various strings for IPFS #7415

Merged
merged 1 commit into from
Dec 13, 2020
Merged

Update various strings for IPFS #7415

merged 1 commit into from
Dec 13, 2020

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Dec 11, 2020

This PR fixes several strings per feedback from @jessicaschilling

Resolves brave/brave-browser#13169

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bbondy bbondy requested a review from yrliou December 11, 2020 21:27
@bbondy bbondy self-assigned this Dec 11, 2020
@bbondy bbondy changed the title Update various strings or IPFS Update various strings for IPFS Dec 12, 2020
@bbondy bbondy merged commit ad3091e into master Dec 13, 2020
@bbondy bbondy deleted the ipfs-text-updates branch December 13, 2020 03:29
@bbondy bbondy added this to the 1.20.x - Nightly milestone Dec 13, 2020
brave-builds pushed a commit that referenced this pull request Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFS text updates
2 participants