Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS text updates #13169

Closed
13 tasks done
bbondy opened this issue Dec 11, 2020 · 0 comments · Fixed by brave/brave-core#7415
Closed
13 tasks done

IPFS text updates #13169

bbondy opened this issue Dec 11, 2020 · 0 comments · Fixed by brave/brave-core#7415
Assignees
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@bbondy
Copy link
Member

bbondy commented Dec 11, 2020

This issue extracts some string suggestions from @jessicaschilling's issue that was originally posted here:
#13125

Infobar

brave://ipfs diagnostic screen

  • Use Start and Stop throughout rather than "Launch" and "Shutdown", to be consistent with other IPFS tools
  • Use IPFS node instead of IPFS Daemon. So "IPFS node status"
  • Launch / Shutdown -> Start / Stop
  • "Addresses Config" sounds like the user can actually change this config, which isn't true. Replace with just Addresses

Settings screen

  • Method to resolve IPFS locations should read Method to resolve IPFS resources, since IPFS isn't location-addressed
  • Subtitle for IPFS public gateway fallback should read Automatically fall back to public IPFS gateway if your local node cannot be reached. (note: two words for "fall back" intentional, since it's a verb)
  • Subtitle for IPFS Companion should read Use the IPFS Companion extension for enhanced IPFS support in Brave, including access to common IPFS tasks from your browser bar.

0 connected peers Interstitial page changes

  • Header should read Can't load IPFS resources using local node
  • Main text should read Failed to use the local IPFS node to load requested IPFS resources. Click the "Proceed" button to use the public gateway instead, and to fall back automatically to the public gateway in the future
  • Advanced text should read Brave cannot load the requested IPFS resources either because the local node did not start, or because there are no connected peers available at the moment. If you choose "Proceed", Brave will automatically fall back to the default public gateway whenever using the local node fails. You can change this behavior at any point in Brave settings.
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Dec 11, 2020
@bbondy bbondy self-assigned this Dec 11, 2020
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 11, 2020
@bbondy bbondy removed the OS/Android Fixes related to Android browser functionality label Dec 11, 2020
@bbondy bbondy added this to the 1.20.x - Nightly milestone Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants