-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extensions support for Tor OTR profile #7304
Conversation
397c56f
to
fc228ee
Compare
5c9109f
to
5300016
Compare
</div> | ||
</extensions-toggle-row> | ||
- </template> | ||
+ <extensions-brave-tor-toggle-row data="[[data]]" delegate="[[delegate]]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As suggested in DM, I suggest injecting the HTML and JS for the new toggle directly to the chromium component via RegisterPolymerTemplateModifications
and RegisterPolymerComponentBehaviors
, so that you can keep the directly-applied styles for the row instead of having to copy/paste. You also wouldn't need this patch or the .js file patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
bbdc3ee
to
cbbc245
Compare
incognitoAccess: isAllowedIncognito, | ||
}); | ||
} | ||
+ setItemAllowedTor(id, isAllowedTor) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you check with @petemill on this? At the very least it can be compressed to one line
1. Add a switch depends on "Allow in private" to enable a extension in Tor 2. When a extension is enabled in Tor, force it to be `split` mode
that network requests will not go through Tor if the extension is running in spanning mode
9304c6d
to
4bac061
Compare
Known CI issue
https://ci.brave.com/job/pr-brave-browser-tor-extensions-support-ios/20/execution/node/216/log/ |
This PR
spanning
mode, warn users that network requests made by the extension will not go through Tor(https://developers.chrome.com/extensions/manifest/incognito)
Security review submitted: https://github.com/brave/security/issues/258
Resolves brave/brave-browser#2761
We can only merge this PR after master upgrade to 88.0.4284.0, otherwise Tor OTR profile won't be destroyed even there is no Tor window opened and that will leave zombie private extensions.This is the change we need
https://chromium-review.googlesource.com/c/chromium/src/+/2434925/6/chrome/browser/ui/browser.cc#605
Master has already upgraded to C88
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan:
Enable extension in Tor
brave://extensions/
and clickDetails
of the extensionAllow in private
Spanning vs Split
Enable extension in Tor
manifest.json
manifest.json
and add"incognito": "split",
and save.brave://extensions/
and turn on developer mode and clickLoad unpacked