Add extension support for Tor windows #2761

AshGrowem · 2018-12-30T07:56:01Z

Description

Brave only has extensions in regular windows, not Private or Tor. Navigating to chrome://extensions/in Private window takes you back to chrome://extensions/ in regular window. Navigating to chrome://extensions/in Tor window takes you to blank page with Extensions is not available to Guest users. on it.

Brave version (brave://version info)

Brave	0.58.18 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Mac OS X
JavaScript	V8 7.1.302.31
Flash	(Disabled)
User Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Brave	0.60.5 Chromium: 72.0.3626.28 (Official Build) dev (64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Mac OS X
JavaScript	V8 7.2.502.13
Flash	(Disabled)
User Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.28 Safari/537.36

Reproducible on current release:

Release: Yes
Dev: Yes

The text was updated successfully, but these errors were encountered:

Techguyprivate · 2018-12-30T10:15:11Z

Allowing extensions in private windows or tor may leave browsing history , traces, cache, cookies & other things . Look at the warning in the picture below. I don't know with high certainty though.

AshGrowem · 2019-01-05T01:08:46Z

@Techguyprivate Totally forgot about that hidden toggle, thanks a bunch! Only works for incognito, but it seems from the comments below that Tor extensions are being worked on

rebron · 2019-01-08T19:52:19Z

cc: @posix4e do you have an update?

posix4e · 2019-01-08T20:45:35Z

Yep we have been working for this and we have something soon. I'll have my friend helping speak up on the issue.

durch · 2019-01-08T20:50:15Z

For sure, started looking into adding privacy pass for tor

posix4e · 2019-01-08T20:55:49Z

@durch Is my friend helping on the project.

tildelowengrimm · 2019-01-10T21:44:01Z

The controls should eventually be the same for Tor windows — just another toggle. But to do that, we ned to get a way from from using guest windows as the basis for Tor, and rebuild them as another type of session more like regular private windows.

posix4e · 2019-01-10T23:09:03Z

@tomlowenthal So confirming the steps are

Rewrite the tor browser mode to work like private mode and remove the existing tor code
Add the ability to add an arbitrary extension to brave tor
Add privacy pass extension by default in tor mode. Should we support it with other modes as well?

Do we wanna install this extension by default, or just keep brave users hitting a ton of captchas til they install the extension?

AshGrowem · 2019-01-11T03:54:11Z

@posix4e I hate captchas and I wasn't even aware of Privacy Pass until you just now mentioned it, and now that you did I'm definitely installing! 😅

I think we can safely assume that users would prefer a default installed extension to having to solve numerous captchas to the point of frustration and then only possibly researching for a solution (most would probably remain ignorant like myself). TorBrowser does the same thing with the "HTTPS Everywhere" extension and many others. Also, Privacy Pass is BSD-3 open source.

Also I found this other well-reviewed and open source anti-CAPTCHA extension, Buster

posix4e · 2019-01-11T04:35:25Z

After further the discussion we will

add in privacy pass support by default into tor mode, and hopefully spruce it up so it’s nice
we will simultaneously add extension support while keeping a close lookout for security and privacy related issues as we go

moo-im-a-cow · 2019-01-23T14:14:32Z

i came here to request extensions in tor just so that i could add privacy pass
tor mode on the light web is literally unusable because of the cloudflare recapcha, which most of the time doesnt even let you complete the capcha, because the ip had already been spamming them and they flat out blocked it

durch · 2019-02-26T20:53:35Z

Just an update, we're ramping up here, hopefully we'll have something to show soonish :)

proteo · 2019-03-05T05:31:56Z

Looking forward for this, thanks!

rulatir · 2019-06-08T14:32:50Z

Any progress since March 5?

gilhrpenner · 2019-07-20T16:52:57Z

Any progress?

durch · 2019-07-22T08:13:39Z

We have a PR to add the Privacy Pass extension here -> brave/brave-core#2576. Extensions in TOR are WIP here -> brave/brave-core#2724, once both of those wrap up PP will be a part of Brave and will be usable in both Private and Tor modes.

rulatir · 2019-07-31T11:52:59Z

"Once both of those wrap up" is a rather fuzzy estimate.

rulatir · 2019-08-23T14:17:24Z

"Once these two prerequisites that have been stalled for months without any sign of progress (apart from bumping the target milestone without explanation) are satisfied, we will have this feature like immediately-ish".

SHHSSH · 2019-12-04T08:40:52Z

Any update on this? We understand the preliminary cautions that should be taken, but for rather secure extensions e.g; NoScript, just as it's in TOR Browser. This would be an added benefit to be available in Brave TOR Windows.

bsclifton · 2020-11-06T20:32:14Z

@NuBz-GeN there are a lot of things to work through and this does have a priority set (relative to other priorities). There was a person working on this over a year ago but that work had been put on hold.

cc: @darkdh who has been solving other Tor issues and @diracdeltas who is familiar with prior work done

bsclifton · 2020-11-10T06:13:09Z

I believe @darkdh is looking at this now - can you confirm? 😄

darkdh · 2020-11-10T18:51:16Z

Currently working on moving tor from session profile to OTR profile (#12429) which will be the ground work for extension support. So I will work on this issue next.

shengchl · 2020-12-16T11:24:34Z

Wow, two years in and we finally nearing the point extensions are allowed in Tor private tab. Kudos to everyone!

Question: why extensions will not route their traffic through tor?

bridiver · 2020-12-16T18:16:10Z

@shengchalover extensions operate in one of two modes: split or spanning. In split mode there is a separate extension process for regular, tor and private modes. In spanning mode there is a single process which is attached to the regular profile. The extension itself specifies spanning or split mode (spanning is the default) and many extensions wouldn't function properly if we forced them into split mode (another option we looked at). This is exactly how it works in Chrome for regular/private mode, they just don't bother to tell you about it. Our compromise was a warning so you at least know what you're getting in to if you allow it.
https://developer.chrome.com/docs/extensions/mv2/manifest/incognito/

bridiver · 2020-12-16T18:21:03Z

also @shengchalover that warning only appears for spanning mode extensions

shengchl · 2020-12-16T20:19:16Z

@bridiver thanks for the input. Is that possible to create a separate toggle to force spanning mode extensions into split mode? Users can then test extensions individually and keep those that work properly. The warning would notify them that this toggle may break extension. Possibly a better option rather then allowing all spanning extensions to do what they want in Tor mode.

bridiver · 2020-12-16T20:27:17Z

@shengchalover unfortunately forcing split mode requires quite a bit of upstream patching which was the other part of the reason we went with the warning. We just can't justify the maintenance cost of the patches for such a niche use case. Remember that this only applies if the extension itself is making any network requests or storing other data about your Tor browsing history. We always display the warning because we don't know if the extension is making any requests or not. In most cases the data that is not going over Tor shouldn't expose anything about what you are doing on Tor unless you have some really sketchy extensions ;)

shengchl · 2020-12-16T20:55:20Z

@bridiver I was mainly interested in the design considerations that lead to such warning, thanks for clarifying.

In a sense Brave positions itself as privacy preserving browser, so if some features harm the characteristics of the anonymizing layer a bit that should not be a big deal.

Having a Tor network one click away from the main browser window is very handy and eliminates the need for vpn in lots of cases. I am truly glad we now one step closer in making the tor-browsing experience more smooth. Can't wait to run PrivacyPass, 1Password and DarkReader in a Tor tab!

Thanks again for the hard work on bringing this proposal to life!

stephendonner · 2021-01-28T20:55:12Z

Verified, following the testplan from brave/brave-core#7304

Brave	1.20.93 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 11.1 (Build 20C69)

added https://chrome.google.com/webstore/detail/1password-extension-deskt/aomjjhallfgjeglblehebfpbcfeobpgk/related?hl=en to Brave Dev
clicked on "hamburger" menu -> extensions
clicked details
enabled Allow in private

file -> New Private Window with Tor
opened browser-profile folder, extensions, aomjjhallfgjeglblehebfpbcfeobpgk
chose Duplicate, copied to ~/Downloads/
opened 4.7.5.90_0
edited manifest.json to have "incognito": "split", saved

enabled Developer mode toggle
clicked Load unpacked, pointed to newly copied and modified manifest.json
clicked on "hamburger" "menu -> extensions

file -> New Private Window with Tor
signed in to 1Password in Brave
loaded wellsfargo.com and confirmed that 1Password was available for the site, in the Tor Private Window

Verification passed on

Brave | 1.20.93 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Verified the test plan from Add extensions support for Tor OTR profile brave-core#7304

Enable the extension in Tor

Ensured the extension is accessible via TOR tab when Allow in private is enabled in the brave://extension details page

Spanning vs Split
Edit manifest.json and added "incognito": "split", and saved file,
Visit brave://extensions/ and turn on developer mode and click Load unpacked

Verified the warning message

Verification passed on

Brave	1.20.95 Chromium: 88.0.4324.96 (Official Build) beta (64-bit)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	Ubuntu 18.04 LTS

Verified the test plan from Add extensions support for Tor OTR profile brave-core#7304

Enable the extension in Tor

Ensured the extension is accessible via TOR tab when Allow in private is enabled in the brave://extension details page

Spanning vs Split
Edit manifest.json and added "incognito": "split", and saved file,
Visit brave://extensions/ and turn on developer mode and click Load unpacked

Verified the warning message

jawadalkassim · 2021-02-10T21:04:43Z

Privacy Pass is not working in TOR and Private mode still stuck on CAPTCHA page but its working in Default normal mode

AshGrowem changed the title ~~Add extensions to private / tor windows~~ Add extensions to private & tor windows Dec 30, 2018

srirambv added feature/extensions needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Jan 1, 2019

srirambv added this to the 1.x Backlog milestone Jan 1, 2019

tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Jan 24, 2019

rebron removed this from the 1.x Backlog milestone Feb 7, 2019

five-c-d mentioned this issue Apr 22, 2019

✨ Feature Suggestion | Better Browser Addons Section privacytools/privacytools.io#852

Closed

bsclifton added the OS/Desktop label Sep 14, 2020

darkdh self-assigned this Nov 19, 2020

darkdh mentioned this issue Dec 1, 2020

Add extensions support for Tor OTR profile brave/brave-core#7304

Merged

23 tasks

darkdh added QA/Test-Plan-Specified QA/Yes labels Dec 3, 2020

diracdeltas mentioned this issue Dec 15, 2020

Implement PrivacyPass #1677

Open

darkdh closed this as completed in brave/brave-core#7304 Dec 15, 2020

darkdh added this to the 1.20.x - Nightly milestone Dec 15, 2020

darkdh added the release-notes/include label Dec 16, 2020

rebron mentioned this issue Jan 15, 2021

Please bring back the proxy auto config menu item. #13588

Open

rebron removed the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Jan 25, 2021

rebron changed the title ~~Add extensions to Tor windows~~ Add extension support for Tor windows Jan 25, 2021

bsclifton added the feature/tor label Jan 26, 2021

stephendonner added the QA Pass-macOS label Jan 28, 2021

GeetaSarvadnya added the QA Pass-Win64 label Feb 1, 2021

btlechowski added the QA Pass-Linux label Feb 1, 2021

LaurenWags mentioned this issue Feb 8, 2021

[Desktop] Release Notes for 1.20.x Release #1 (Release Channel) #14035

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add extension support for Tor windows #2761

Add extension support for Tor windows #2761

AshGrowem commented Dec 30, 2018 •

edited

Loading

Techguyprivate commented Dec 30, 2018

AshGrowem commented Jan 5, 2019 •

edited

Loading

rebron commented Jan 8, 2019

posix4e commented Jan 8, 2019

durch commented Jan 8, 2019

posix4e commented Jan 8, 2019

tildelowengrimm commented Jan 10, 2019

posix4e commented Jan 10, 2019

AshGrowem commented Jan 11, 2019 •

edited

Loading

posix4e commented Jan 11, 2019

moo-im-a-cow commented Jan 23, 2019

durch commented Feb 26, 2019

proteo commented Mar 5, 2019

rulatir commented Jun 8, 2019 •

edited

Loading

gilhrpenner commented Jul 20, 2019

durch commented Jul 22, 2019

rulatir commented Jul 31, 2019

rulatir commented Aug 23, 2019 •

edited

Loading

SHHSSH commented Dec 4, 2019

bsclifton commented Nov 6, 2020

bsclifton commented Nov 10, 2020 •

edited

Loading

darkdh commented Nov 10, 2020

shengchl commented Dec 16, 2020

bridiver commented Dec 16, 2020 •

edited

Loading

bridiver commented Dec 16, 2020

shengchl commented Dec 16, 2020

bridiver commented Dec 16, 2020 •

edited

Loading

shengchl commented Dec 16, 2020

stephendonner commented Jan 28, 2021 •

edited by btlechowski

Loading

jawadalkassim commented Feb 10, 2021 •

edited

Loading

Add extension support for Tor windows #2761

Add extension support for Tor windows #2761

Comments

AshGrowem commented Dec 30, 2018 • edited Loading

Description

Brave version (brave://version info)

Reproducible on current release:

Techguyprivate commented Dec 30, 2018

AshGrowem commented Jan 5, 2019 • edited Loading

rebron commented Jan 8, 2019

posix4e commented Jan 8, 2019

durch commented Jan 8, 2019

posix4e commented Jan 8, 2019

tildelowengrimm commented Jan 10, 2019

posix4e commented Jan 10, 2019

AshGrowem commented Jan 11, 2019 • edited Loading

posix4e commented Jan 11, 2019

moo-im-a-cow commented Jan 23, 2019

durch commented Feb 26, 2019

proteo commented Mar 5, 2019

rulatir commented Jun 8, 2019 • edited Loading

gilhrpenner commented Jul 20, 2019

durch commented Jul 22, 2019

rulatir commented Jul 31, 2019

rulatir commented Aug 23, 2019 • edited Loading

SHHSSH commented Dec 4, 2019

bsclifton commented Nov 6, 2020

bsclifton commented Nov 10, 2020 • edited Loading

darkdh commented Nov 10, 2020

shengchl commented Dec 16, 2020

bridiver commented Dec 16, 2020 • edited Loading

bridiver commented Dec 16, 2020

shengchl commented Dec 16, 2020

bridiver commented Dec 16, 2020 • edited Loading

shengchl commented Dec 16, 2020

stephendonner commented Jan 28, 2021 • edited by btlechowski Loading

jawadalkassim commented Feb 10, 2021 • edited Loading

AshGrowem commented Dec 30, 2018 •

edited

Loading

AshGrowem commented Jan 5, 2019 •

edited

Loading

AshGrowem commented Jan 11, 2019 •

edited

Loading

rulatir commented Jun 8, 2019 •

edited

Loading

rulatir commented Aug 23, 2019 •

edited

Loading

bsclifton commented Nov 10, 2020 •

edited

Loading

bridiver commented Dec 16, 2020 •

edited

Loading

bridiver commented Dec 16, 2020 •

edited

Loading

stephendonner commented Jan 28, 2021 •

edited by btlechowski

Loading

jawadalkassim commented Feb 10, 2021 •

edited

Loading