Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12347: Fix lint error + rust deps for CI #6963

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Fix #12347: Fix lint error + rust deps for CI #6963

merged 2 commits into from
Oct 27, 2020

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Oct 27, 2020

Resolves brave/brave-browser#12347

Submitter Checklist:

Test Plan:

Not required, CI should pass.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde requested a review from NejcZdovc October 27, 2020 18:00
@jumde jumde self-assigned this Oct 27, 2020
@jumde jumde changed the title Fix #12347: Fix lint error in browser/ui/webui/brave_webui_source.cc Fix #12347: Fix lint error + rust deps for CI runs Oct 27, 2020
@jumde jumde changed the title Fix #12347: Fix lint error + rust deps for CI runs Fix #12347: Fix lint error + rust deps for CI Oct 27, 2020
@jumde jumde requested review from tmancey and antonok-edm October 27, 2020 18:57
Copy link
Collaborator

@antonok-edm antonok-edm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjozwiak
Copy link
Member

Looks like test-install failed on macOS as per https://ci.brave.com/job/pr-brave-browser-fix_lint-macos/3/execution/node/274/log/. Pretty sure it's a known intermittent issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix lint error + rust deps build issue on CI
4 participants