Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete signal to operational patterns #12347

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Conversation

LorenzoMinto
Copy link
Contributor

@LorenzoMinto LorenzoMinto commented Feb 21, 2022

Resolves brave/brave-browser#17502

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@LorenzoMinto LorenzoMinto self-assigned this Feb 21, 2022
@LorenzoMinto LorenzoMinto force-pushed the issues/17502 branch 3 times, most recently from f41e313 to ffb9236 Compare February 22, 2022 09:50
@LorenzoMinto LorenzoMinto requested a review from aseren February 22, 2022 09:58
@LorenzoMinto LorenzoMinto marked this pull request as ready for review February 28, 2022 17:34
@LorenzoMinto LorenzoMinto requested a review from fmarier February 28, 2022 17:34
@github-actions github-actions bot added rebase and removed rebase labels Feb 28, 2022
@LorenzoMinto LorenzoMinto merged commit de4c6fa into master Mar 7, 2022
@LorenzoMinto LorenzoMinto deleted the issues/17502 branch March 7, 2022 10:54
@LorenzoMinto LorenzoMinto added this to the 1.38.x - Nightly milestone Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request server-side data deletion when user opts out of operation pattern collection
5 participants