Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 84.0.4147.68 to Chromium 84.0.4147.85 (1.11.x). #6054

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jul 9, 2020

Fixes brave/brave-browser#10594
Related PR: brave/brave-browser#10674

Uplift from #6025

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Upgrade patches from Chromium 84.0.4147.68 to Chromium 84.0.4147.85.
@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Jul 9, 2020
@mkarolin mkarolin added this to the 1.11.x - Release milestone Jul 9, 2020
@mkarolin mkarolin requested a review from a team July 9, 2020 15:08
@mkarolin mkarolin requested a review from bridiver as a code owner July 9, 2020 15:08
@mkarolin mkarolin self-assigned this Jul 9, 2020
@mkarolin
Copy link
Collaborator Author

mkarolin commented Jul 9, 2020

CI:
audit-deps failed on all platforms - a known issue.
audit-network failed on Linux - a known issue.
Everything else passed.

@kjozwiak
Copy link
Member

kjozwiak commented Jul 9, 2020

@mkarolin looks like the only one that failed that's a bit surprised is audit-network as per https://ci.brave.com/job/pr-brave-browser-84.0.4147.85-1.11.x/3/execution/node/475/log/. I'm not 100% sure if the above is worth restarting but haven't seen that failure in a while.

Other than the above one, the remaining are audit-deps failures due to lodash which is a known issue and fixed in 1.12.x and 1.13.x 👍

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit a568efc into 1.11.x Jul 9, 2020
@kjozwiak kjozwiak deleted the 84.0.4147.85-1.11.x branch July 9, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants