Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 84.0.4147.68 to Chromium 84.0.4147.85. #10594

Closed
mkarolin opened this issue Jul 7, 2020 · 4 comments · Fixed by #10595 or brave/brave-core#6025
Closed

Upgrade from Chromium 84.0.4147.68 to Chromium 84.0.4147.85. #10594

mkarolin opened this issue Jul 7, 2020 · 4 comments · Fixed by #10595 or brave/brave-core#6025
Assignees

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Jul 7, 2020

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/84.0.4147.68..84.0.4147.85?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

No specific code changes in Brave (only line number changes in patches).

@kjozwiak
Copy link
Member

kjozwiak commented Jul 9, 2020

@brave/legacy_qa when running through the above, please make sure that we check the area's @mkarolin mentioned via #10364 (comment).

QA also ran though #10572 to ensure that nothing obvious regressed before uplifting C84 into 1.11.x.

@LaurenWags
Copy link
Member

Verification in progress with

Brave	1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
Revision	e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS	macOS Version 10.14.6 (Build 18G3020)
  • Verified areas mentioned in Upgrade from Chromium 83 to Chromium 84 #10364 (comment)
  • Confirmed able to download extensions from Chrome webstore on a clean profile
  • Using an old profile with extensions, confirmed extensions updated
  • Confirmed changes to brave://settings/shields are preserved on browser exit and restart
  • Confirmed site specific changes to shields are preserved on browser exit and restart
  • Confirmed Brave version shows correctly on brave://settings, brave://settings/help, brave://version
  • Confirmed able to automatically send crash reports (when setting is enabled in brave://settings/privacy)
  • Confirmed able to manually send crash reports (after browser restart) when setting is disabled
  • Confirmed both crash reports were viewable on the server
  • Confirmed able to import passwords from Chrome (on macOS)
  • Generally confirmed buttons, toggles, links, checkboxes look to be using Brave coloring
  • Generally confirmed the look of brave://settings, brave://history, brave://downloads, brave://bookmarks, and brave://extensions matches Brave coloring
  • Confirmed able to search on brave://settings, brave://bookmarks, and brave://history pages

TBD:

  • Settings page - checking settings modifications, e.g. "clear data on exit", content settings categories, brave theme, strings, etc.

@LaurenWags
Copy link
Member

Per discussion with @srirambv removed OS/Android tag and logged android specific issue - #10711

@LaurenWags
Copy link
Member

LaurenWags commented Jul 14, 2020

removing QA/Yes and adding QA/No as this issue is superseded by #10714

also removing release-notes/include and adding release-notes/exclude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment