Video contribution settings should not apply to non-video "media" sites #6034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#10546
This change replaces
LedgerImpl::SaveMediaVisit
with two new methods:LedgerImpl::SaveVisit
LedgerImpl::SaveVideoVisit
Code in "media" that correspond to "video" sites use
SaveVideoVisit
while others useSaveVisit
.Additional changes:
OnSaveMediaVisit
callbacks have been replaced with empty lambdas.Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
brave://rewards
.https://github.com/laurenwags
.https://vimeo.com/bravelaurenwags
Reviewer Checklist:
After-merge Checklist:
changes has landed on.