Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] GH not added to AC when "Allow contribution to videos" is unchecked #10546

Closed
LaurenWags opened this issue Jul 2, 2020 · 1 comment · Fixed by brave/brave-core#6034

Comments

@LaurenWags
Copy link
Member

Description

If you uncheck "Allow contributions to videos" in auto contribute settings, GitHub pages (ex. github.com/laurenwags) will not be added to your AC list even if it meets the length/time requirements.

Steps to Reproduce

  1. Clean profile 1.10.x
  2. Enable Rewards
  3. Modify AC settings to uncheck "Allow contribution to videos"
  4. Visit a GH page for a user for length/time required.

Actual result:

GH page is not added to AC list, if you open DB, it is not added in DB either

Expected result:

Since the GH page is not a video, it should be added to AC list

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @brave/legacy_qa

@LaurenWags
Copy link
Member Author

LaurenWags commented Aug 14, 2020

Verified passed with

Brave | 1.13.71 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description
  • Confirmed GH creators are added to AC when "Allow contribution to videos" is both checked and unchecked
  • Confirmed YT and Vimeo creators are not added to AC when "Allow contribution to videos" is unchecked
  • Rechecked the setting. Played YT and Vimeo videos. Confirmed YT and Vimeo creators are added to AC when "Allow contribution to videos" is checked

Verification passed on

Brave 1.13.71 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
Revision d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS Ubuntu 18.04 LTS
  • Verified test plan from Video contribution settings should not apply to non-video "media" sites brave-core#6034
    image
  • Verified STR from description
  • Confirmed GH creators are added to AC when "Allow contribution to videos" is both checked and unchecked
  • Confirmed YT and Vimeo creators are not added to AC when "Allow contribution to videos" is unchecked
  • Rechecked the setting. Played YT and Vimeo videos. Confirmed YT and Vimeo creators are added to AC when "Allow contribution to videos" is checked

Verification passed on


Brave | 1.13.72 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | Windows 10 OS Version 1903 (Build 18362.1016)


  • Verified test plan from Video contribution settings should not apply to non-video "media" sites brave-core#6034
    image
  • Verified STR from description
  • Confirmed GH creators are added to AC when "Allow contribution to videos" is both checked and unchecked
  • Confirmed YT and Vimeo creators are not added to AC when "Allow contribution to videos" is unchecked
  • Rechecked the setting. Played YT and Vimeo videos. Confirmed YT and Vimeo creators are added to AC when "Allow contribution to videos" is checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment